Request for commit access to git-plugin

42 views
Skip to first unread message

Christian Galsterer

unread,
Apr 25, 2015, 1:21:20 AM4/25/15
to jenkin...@googlegroups.com
Hi,

I would like to ask for commit access for the git-plugin as my pull request is pending for more then 2 weeks without feedback any I also didn't get response for my request for review of the PR here in the group.

My GitHub account: christiangalsterer

Thanks in advance

Christian

Daniel Beck

unread,
Apr 25, 2015, 4:59:47 AM4/25/15
to jenkin...@googlegroups.com

On 25.04.2015, at 07:21, Christian Galsterer <christian...@gmx.de> wrote:

> without feedback

What about the review comment you got?

Note that there's no notification when a pull request is updated, so a simple 'I addressed your review comment' would be helpful.

Message has been deleted

Christian Galsterer

unread,
Apr 25, 2015, 6:28:16 AM4/25/15
to jenkin...@googlegroups.com, m...@beckweb.net
Hi,

you are right. I updated the code already a week ago, but I didn't left a reply on the review comment. I left a comment now.

Br
Christian

nicolas de loof

unread,
Apr 25, 2015, 7:03:03 AM4/25/15
to jenkin...@googlegroups.com, m...@beckweb.net

I've been on vacation for 2 weeks, will review your PR asap. Please note 1 week for such a popular plugin is not a long delay to wait for review/feedback.


--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/ce11e102-2a63-4d48-8e59-3ebc22a171d5%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Christian Galsterer

unread,
Apr 25, 2015, 7:15:18 AM4/25/15
to jenkin...@googlegroups.com, m...@beckweb.net
Thanks for looking into the PR.

Kanstantsin Shautsou

unread,
Apr 27, 2015, 5:14:22 AM4/27/15
to jenkin...@googlegroups.com, m...@beckweb.net
Git plugin has design issues, that's why single fixes that resolve only one small part of issue and adding other problems not merged.

nicolas de loof

unread,
Apr 27, 2015, 5:22:44 AM4/27/15
to jenkin...@googlegroups.com, m...@beckweb.net
Which PR is this about ?

Christian Galsterer

unread,
Apr 27, 2015, 12:09:20 PM4/27/15
to jenkin...@googlegroups.com, m...@beckweb.net
Hi,

it was about https://github.com/jenkinsci/git-plugin/pull/315, but I saw that you found the PR in the meantime and it is already merged.

Thanks for reviewing and merging.

Br
Christian
Reply all
Reply to author
Forward
0 new messages