Discard build enhancement: to core or to plugin?

[martinda]

Hi,

The built-in build discard logic discards builds if they either exceed a number of days, or if they are beyond a certain position in the history. In my GSoC proposal I suggested combining these two conditions with an "AND" instead of an "OR". It turns out this can be implemented as an extension (plugin) like the enhanced build discarder plugin, or build right into the core. I don't think changing that plugin will help because that plugin extends the core feature without changing the conditional, so the core algorithm has to be slightly modified either way.

Opinions? Should it be an new plugin or should it build into the core? Or maybe it does not matter.

Thanks,

Martin

[Jesse Glick]

On Mon, Jun 24, 2019 at 7:23 PM martinda <martin....@gmail.com> wrote:
> I don't think changing that plugin will help because that plugin extends the core feature without changing the conditional

So improve the plugin.

[Benjamin Beggs]

I believe I can override the core conditionals with an extension, so core modification may be unnecessary.

[Mark Strasser]

Seconded. This sounds like something useful but not required by most users.