Gerrit Trigger Plugin - custom label support

[george....@ullink.com]

Hi!

I'm relying on gerrit trigger plugin as the connecting layer between my Jenkins & Gerrit infrastructure. Recently, a need came up to introduce a third label in gerrit, besides Code-Review and Verified. But so far I saw that GTP doesn't support posting votes on custom labels... so I was thinking of developing this feature and adding it as a pull request.

Has anyone thought of / attempted this before? Was this custom label support ever considered by the developers and if yes, what made them back away?

Any help / info is much appreciated!

Thanks!

Visit: itiviti.com / ullink.com »

Read the latest news from Itiviti »

The information contained in or attached to this email is strictly confidential. If you are not the intended recipient, please notify us immediately by telephone and return the message to us.

Email communications by definition contain personal information. The ITIVITI group of companies (of which ULLINK forms part) is subject to European data protection regulations. ULLINK’s Privacy Policy is available at www.ullink.com. ULLINK expects the recipient of this email to be compliant with ULLINK’s Privacy Policy and applicable regulations. Please advise us immediately at datapro...@ullink.com if you are not compliant with these.

[Björn Pedersen]

Am Donnerstag, 23. August 2018 14:45:12 UTC+2 schrieb george....@ullink.com:

Hi!

I'm relying on gerrit trigger plugin as the connecting layer between my Jenkins & Gerrit infrastructure. Recently, a need came up to introduce a third label in gerrit, besides Code-Review and Verified. But so far I saw that GTP doesn't support posting votes on custom labels... so I was thinking of developing this feature and adding it as a pull request.

Has anyone thought of / attempted this before? Was this custom label support ever considered by the developers and if yes, what made them back away?

Any help / info is much appreciated!

We sometime setting custom labels from jobs as well, by just using the ssh-cli.

 sh """ ssh -p 29418 <gerriturl> gerrit review --label FinalBuild=+1 --submit ${GERRIT_PATCHSET_REVISION} """
 
As we need those custom votes only on special jobs (or only for parts of the jobs) , this is the easier approach for us.

Björn

[George Cimpoies]

Thanks very much for your response! If anyone else has questions on the ssh method, here's the documentation: https://review.openstack.org/Documentation/cmd-review.html

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/ff57f325-2fb5-4661-98a3-ed442cf1503e%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--

George Cimpoies

R&D • Itiviti
Software Engineer

Mobile: +40 751 048 489
george....@ullink.com

1 Victor Deleu Street | Cluj-Napoca, Cluj 400112