TransientActionFactory question

[Nozim Islamov]

Is there any way to include side-panel to actions that are created by TransientActionFactory?

[jn...@cloudbees.com]

HI,

If I understand your question correctly, you just need to return non-null for getDisplayName and getIconFileName in your Action[1]

/James

[1] https://javadoc.jenkins.io//hudson/model/Action.html

[Nozim Islamov]

Actually, I am using RunAction2 interface, and I am using TransientActionFactory to show it for every Run, please refer to this git: https://github.com/M1ZoN/promoted/tree/SimpleBuildWrapper

ActionFactory: https://github.com/M1ZoN/promoted/blob/SimpleBuildWrapper/src/main/java/io/jenkins/plugins/sample/MyActionFactory.java

RunAction2: https://github.com/M1ZoN/promoted/blob/SimpleBuildWrapper/src/main/java/io/jenkins/plugins/sample/PromotedBuildAction.java

Jelly for Action: https://github.com/M1ZoN/promoted/blob/SimpleBuildWrapper/src/main/resources/io/jenkins/plugins/sample/PromotedBuildAction/index.jelly

[Daniel Beck]

The run is null, so there's nothing to get a sidepanel from.

The RunAction2 special behavior isn't supported by TransientActionFactory, so you need to add a constructor argument to end up with a reference to the Run. Could be as designed based on the RunAction2 Javadoc. The problem it solves is one that isn't trivial to do otherwise (having a reference to the run after loading from disk), so I can see why this might get ignored in the transient action factory case, that's easy to solve.

Here's a patch to make it work: https://gist.github.com/daniel-beck/34b7a1425f85bfa499bd43823d17f030

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/c4e9df21-9b96-4f3f-9acb-a11584cad93cn%40googlegroups.com.

 

[Nozim Islamov]

Thank you so much Daniel Beck, that really worked for me!