Request to review PRs for display-url-api and blueocean-display-url plugins

[Victor Martinez]

Hi there,

I'd like to ask for some reviews for the below PRs:

• https://github.com/jenkinsci/display-url-api-plugin/pull/25
• https://github.com/jenkinsci/display-url-api-plugin/pull/26
• https://github.com/jenkinsci/blueocean-display-url-plugin/pull/24

Last one depends on the previous two.

Thanks so much

[Gavin Mogan]

I'll do a formal review of the last one when the first two are finalized and released.

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/c4e1ab61-ab22-43b6-969c-0a00faa5a1c2%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Jesse Glick]

On Fri, Jun 28, 2019 at 11:36 AM 'Gavin Mogan' via Jenkins Developers
<jenkin...@googlegroups.com> wrote:
> I'll do a formal review of the last one when the first two are finalized and released.

When a new API is being proposed, it is necessary to review the
proposed usages in tandem with the API itself. Otherwise you are not
verifying that the API solves a tangible problem in the most
straightforward manner. JEP-305 additionally helps you run CI against
downstream PRs, which is why #26 should first be merged and then #25
synchronized with `master`.