http-request-plugin: workflow support request for feedback

[martinda]

Janario and others,

I want to add workflow support to the http-request-plugin. As you are the author of the plugin, I would like your feedback on the following:

1. Some items are marked as "to be deprecated" in the global config. I am proposing to deprecate them, so there are fewer features to worry about.
2. Baseline version: from 1.509.4 to 1.609.1: workflow support requires a baseline upgrade. Is it a concern to upgrade the baseline?
3. I prepared a pull-request, can you please review it?
4. Default values in the jelly forms are not linked to default values in the DescriptorImpl, and sometimes differ. This is a bit confusing, as default values in testing are not the same as the default plugin values when using the plugin, I want the change the jelly forms to read the defaults from the DescriptorImpl.
   

The plan I am following is to propose TWO pull requests:

1. Pull-request 1: Workflow readiness preparation (see https://github.com/jenkinsci/http-request-plugin/pull/13)
1. Add tests
2. Format the code according to the Workflow COMPATIBILITY.md guidelines
3. Align jelly form default values to DescriptorImpl default values (not yet present in the pull-request)
   
4. Release a working version of the plugin
2. Pull-request 2: Implement a custom workflow step (to be written as soon as I understand how to do it)
   
1. Instead of calling the plugin from a generic "step()" call, support a custom step for the plugin (httpRequest).
2. Add workflow specific tests
3. Send pull-request, respond/implement feedback
   
4. Release
   

Thanks,

Martin

[Antonio Muñiz]

On Mon, Jan 18, 2016 at 3:11 PM, martinda <martin....@gmail.com> wrote:

Pull-request 2: Implement a custom workflow step

Why do you need this part? If it's for "esthetic" reasons you can wait for JENKINS-29922 to be implemented.

--

Antonio Muñiz

Software Engineer
CloudBees, Inc.

[martinda]

On Monday, January 18, 2016 at 9:22:45 AM UTC-5, Antonio Muñiz wrote:

On Mon, Jan 18, 2016 at 3:11 PM, martinda <martin....@gmail.com> wrote:

Pull-request 2: Implement a custom workflow step

Why do you need this part? If it's for "esthetic" reasons you can wait for JENKINS-29922 to be implemented.

In the end I want to return the content of http-request to a variable for further processing, and for that Jesse says I need a custom workflow step, see https://groups.google.com/forum/#!topic/jenkinsci-dev/3fSQoxoZVMg

Martin