Behaviour-Change for PageDecorator footer element
8 views
Skip to first unread message
Björn Pedersen
Jul 30, 2015, 3:49:54 AM7/30/15
to Jenkins Developers
Hi,
This change: https://github.com/jenkinsci/jenkins/commit/e0fcf91910782cea30d5bacb1f15077088628ef3
moved the footer parts added by PageDecorators (specifically the https://software.sandia.gov/trac/fast/wiki/PageMarkup plugin) into a row/column div.
This causes misfunction if on tries to use position:absolute on these parts to get them e.g. on top of the page.
I think thes decorator parts should stay directly in front of </body> as the code comments in https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/hudson/model/PageDecorator.java
indicate.
Actually it would even be nice to get some more points to inejct html:
Best regards,
Björn
This change: https://github.com/jenkinsci/jenkins/commit/e0fcf91910782cea30d5bacb1f15077088628ef3
moved the footer parts added by PageDecorators (specifically the https://software.sandia.gov/trac/fast/wiki/PageMarkup plugin) into a row/column div.
This causes misfunction if on tries to use position:absolute on these parts to get them e.g. on top of the page.
I think thes decorator parts should stay directly in front of </body> as the code comments in https://github.com/jenkinsci/jenkins/blob/master/core/src/main/java/hudson/model/PageDecorator.java
indicate.
Actually it would even be nice to get some more points to inejct html:
- in <header> -> is available
- in or before body > div#page-head
- before </body> (outside any layout divs, maybe hidden by default) -> changed with the mentioned change
- inside the <footer> as visible elements
Best regards,
Björn
Reply all
Reply to author
Forward
0 new messages