Towards new kubernetes-client 6.x

[Vincent Latombe]

Hello,

https://github.com/jenkinsci/kubernetes-client-api-plugin bundles today version 5.x of fabric8 kubernetes-client.

A new major version of this library (6.x) has been available for a while and has breaking changes (See https://github.com/fabric8io/kubernetes-client/blob/v6.3.1/doc/MIGRATION-v6.md for details) requiring coordinated changes across plugins using this library in the Jenkins ecosystem.

I've built a series of plugin incremental builds with this new version. I believe I am covering all existing plugins in the Jenkins OSS ecosystem using this library. All existing tests are passing.

* https://repo.jenkins-ci.org/incrementals/org/jenkins-ci/plugins/kubernetes-client-api/6.3.1-205.vea_a_fc21de909/kubernetes-client-api-6.3.1-205.vea_a_fc21de909.hpi

* https://repo.jenkins-ci.org/incrementals/org/jenkinsci/plugins/kubernetes-credentials/0.9.1-rc137.c18250c59a9b/kubernetes-credentials-0.9.1-rc137.c18250c59a9b.hpi

* https://repo.jenkins-ci.org/incrementals/org/csanchez/jenkins/plugins/kubernetes/3785.v5f32c515c19b/kubernetes-3785.v5f32c515c19b.hpi

* https://github.com/jenkinsci/kubernetes-cli-plugin/pull/101 (incrementals not enabled on that repository)

Unfortunately, the UC doesn't provide any facility to declare such incompatibility (e.g. https://issues.jenkins.io/browse/JENKINS-49651), so this kind of breaking upgrade is unfortunately unavoidable.

If you have a consuming plugin using this library, you will need to make necessary changes before upgrading the client library.

If you are just a kubernetes-plugin user, please don't rush any kubernetes-client-api upgrade, wait for the new kubernetes-plugin version to be available, and it will pull the required transitive dependency upgrade.

I plan to make a coordinated release early next week. Please hold on applying any upgrade to kubernetes-client-api plugin unless you get the matching updates from consuming plugins!

Regards,

Vincent

[Daniel Beck]

On Thu, Jan 5, 2023 at 5:18 PM Vincent Latombe <vincent...@gmail.com> wrote:

A new major version of this library (6.x) has been available for a while and has breaking changes (See https://github.com/fabric8io/kubernetes-client/blob/v6.3.1/doc/MIGRATION-v6.md for details) requiring coordinated changes across plugins using this library in the Jenkins ecosystem.

Would a new library plugin for the new major release not solve this problem in a way much less likely to affect existing users? There's already jquery and jquery3-api, commons-lang-api and commons-lang3-api, jackson-databind and jackson2-api, bootstrap4-api and bootstrap5-api, etc. all doing it that way AFAIUI.

[jn...@cloudbees.com]

the package names are still the same as far as I understand, and this would still have issues due to the nature of the dependencies.

as k8s has dependencies on both -creds and -api  if the creds where updated to use the new -6-api when the classess that k8s would see would be a bit "iffy" would they not (as they would see both -6-api and -api) whith some interesting conflicting results....

>  i, jackson-databind and jackson2-api, bootstrap4-api and bootstrap5-api   . all doing it that way AFAIUI.

because the underlying libraries are well behaved and used a new namespace for the new version? (at least the java ones - I do not know about the JS stuff...)

[jn...@cloudbees.com]

> I've built a series of plugin incremental builds with this new version. I believe I am covering all existing plugins in the Jenkins OSS ecosystem using this library. All existing tests are passing.

kubernetes-credential-provider uses the api.

/James

[Vincent Latombe]

Unfortunately not, as James pointed out, the package on fabric8 side is not updated to a new one, so both plugins wouldn't be able to co-exist in the classpath.

Vincent

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CAMo7PtLoJKB3o-ugJmoH6DhkbKVzLLEnOcVSqhKZqjv1TgQgGA%40mail.gmail.com.

[Vincent Latombe]

> kubernetes-credential-provider uses the api.

I just checked it (https://github.com/jenkinsci/kubernetes-credentials-provider-plugin/pull/72), it doesn't seem to require any update considering its api usage.

There is one deprecated code usage that can be cleaned up but is not mandatory, and one test usage that should be updated, but it doesn't seem to fail currently.

Vincent

--

You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/e4bbbbe5-7584-40fd-8f4a-2a47cc963f2bn%40googlegroups.com.

[Jesse Glick]

On Thu, Jan 5, 2023 at 2:35 PM Vincent Latombe <vincent...@gmail.com> wrote:

the package on fabric8 side is not updated to a new one, so both plugins wouldn't be able to co-exist in the classpath.

You can simultaneously run multiple wrapper plugins with the same package, so long as any given caller’s transitive dependency closure only uses one of them. I think that means there would have to be a `kubernetes-credentials-6` plugin, since its `kubernetes-client-api-6` dependency makes it implicitly incompatible. Seems like a mess.

Setting that aside, it would be awkward to create a new `kubernetes-client-api-6` plugin because then people would be left with the old `kubernetes-client-api` installed and enabled but unused, and need to manually clean up.

Pending JENKINS-49651, I agree that just releasing the batch of updates on the same day and asking users to please refrain from partial updates is the least disruptive option.

[Mark Waite]

Several users have reported an issue with the most recent releases.  More information at https://issues.jenkins.io/browse/JENKINS-70392 

[Vincent Latombe]

Thanks, I'm on it.

Vincent

--

You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/cc4f2dfe-6733-448c-bced-985820e122d9n%40googlegroups.com.