Jenkins junit plugin - contributing Skipped tests reporting

[Nir Gilboa]

Hi,

I've added the ability to report skipped tests

https://github.com/nirgilboa/junit-plugin/tree/include-skipped-results

However I've not been able to figure out how to implement the /summary page for a Skipped test, so that expanding (by click on the '+') on the Test Results page will correctly show the skip message.

I can't seem to find the correct file Java/jelly which is generating this page.

Example summary url:

lastBuild/testReport/all/testName/summary

I'd really appreciate a bit of help :-)

Thanks,

Nir

[Robert Sandell]

This one maybe? https://github.com/nirgilboa/junit-plugin/blob/master/src/main/resources/hudson/tasks/junit/CaseResult/summary.jelly 

/B

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/5a030431-2b76-45c6-88d0-93ebdcc362cd%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

--

Robert Sandell

Software Engineer

CloudBees, Inc.

E: rsan...@cloudbees.com

Twitter: robert_sandell

[Nir Gilboa]

Thank you !

Yes I did manage to find that, and I see that index.jelly is including it via:

<table style="margin-top: 1em; margin-left:0em;">
<j:forEach var="action" items="${it.testActions}">
    <st:include page="summary.jelly" from="${action}" optional="true" it="${action}" />
</j:forEach>
</table>

However I don't understand why this would be executed for failed tests, but not for skipped ones..

getTestActions() doesn't seem to depend on the test result, at least not that I could find.

Hope you're able to shed some light :)

Thanks again!

Nir

[Robert Sandell]

That include is for the summary.jelly of whatever actions the CaseResult contains, so that's not the summary.jelly of the CaseResult itself.

But there is a bit further down

<j:if test="${!empty(it.skippedMessage)}">

So if the test is skipped it's message/reason should show up like for example here.

/B

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/d2ec1d21-93c0-4ac5-9917-371e986f4f90%40googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

[Nir Gilboa]

Thanks, that helped :)

Do you mind having a look again to see if I missed anything before I submit a PR ?

https://github.com/nirgilboa/junit-plugin/tree/include-skipped-results

Also do you think I should make this configurable ?

i.e. "Include Skipped Tests in Test Result" checkbox in the plugin config

[Robert Sandell]

Den mån 25 juni 2018 kl 16:25 skrev Nir Gilboa <gilbo...@gmail.com>:

Thanks, that helped :)

Do you mind having a look again to see if I missed anything before I submit a PR ?

https://github.com/nirgilboa/junit-plugin/tree/include-skipped-results

Better to just file the PR, that's what it's meant for :)

You can mention @jenkinsci/code-reviewers in the PR to get some seasoned eyes on it to help you out.

 

Also do you think I should make this configurable ?

i.e. "Include Skipped Tests in Test Result" checkbox in the plugin config

Since there already is code that shows the skipped tests I'm not sure what you mean by this?

 

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/8db129b6-6b56-49e1-960d-a9c684aafd67%40googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

[Nir Gilboa]

The change I would like to submit adds a summary of Skipped Tests to the main Test Result (See screenshot below).

Question is whether to make it being there configurable..

[Ullrich Hafner]

I don’t think that it needs to be configurable. 

In the skipped tab there is also the + button visible. What would be shown here for skipped tests?

Am 26.06.2018 um 09:06 schrieb Nir Gilboa <gilbo...@gmail.com>:

The change I would like to submit adds a summary of Skipped Tests to the main Test Result (See screenshot below).

Question is whether to make it being there configurable..

<Auto Generated Inline Image 1.png>

To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/d4fa454a-ee91-4dd9-82bf-bdaab1046712%40googlegroups.com.

For more options, visit https://groups.google.com/d/optout.

<Auto Generated Inline Image 1.png>

[Nir Gilboa]

I added the ability to display the "Skip Message" there, based on the standard "message" attribute present in the JUnit XML

Tthis was already displayed if you clicked on the specific test details.

Additionally as before, it may include "Standard Output", "Standard Error", "Error Details" and "Stack Trace", which are usually present in Failed tests

[Nir Gilboa]

Robert / Ullrich: could you please review the PR I submitted or mention someone who can ?

Apparently mentioning teams inside the GitHub org is reserved to members..

Thanks!

Nir

[Nir Gilboa]

My PR [1] was reviewed and approved by Ullrich - thank you !

Any additional feedback ?

Thanks,

Nir

[1]

https://github.com/jenkinsci/junit-plugin/pull/106