Re: Custom Tools Plugin: Modification Request

65 views
Skip to first unread message

Oleg Nenashev

unread,
Jul 29, 2015, 3:54:15 AM7/29/15
to Karan Anand, ryan.c...@gmail.com, JenkinsCI Developers
Hi Karan,

It's great the the plugin work well for your installation. Below you can find answers to your questions. I've also CCed the Jenkins Developers mailing list just to let other contribute or describe additional use-cases if they want.

Support for Nuget packages (which is basically just another compressed file)

I suppose you want to add a new Tool Installer. If yes, such tool installer would be useful even outside Custom Tools Plugin. ToolInstaller is a universal Jenkins core extension point, which is being used by many plugins. I would propose to add such ToolInstaller to Nuget Plugin. After implementing a ToolInstaller you will automatically get it in Custom Tools as well. 

You can find several simple examples here in Extra Tool Installers Plugin

Support versioning of tools (maybe as simple as reading it from name of file)

This feature is supported by the current version of the plugin (starting from 0.4). It uses the extended choice as a wrapper. I've added some info to the Wiki page: https://wiki.jenkins-ci.org/display/JENKINS/Custom+Tools+Plugin 

You can also see a brief description of the versioning support here: http://www.youtube.com/watch?v=D9Wxvex8o4E&t=17m22s 

Run ‘mvn install’ -> I see most of the tests erroring out (logs attached)

It smells to be a platform-specific issue, because you're using Windows. During the previous plugin development iterations I used to build the plugin on Windows as well, but I had Cygwin on my machine. You could try to build the plugin on a VM or just install Cygwin. Currently the tests are working correctly on my machine. 

Alternatively, I tried to run Jenkins using ‘mvn hpi:run’ -> In this case I am not able to see the custom tool section show up when I try to configure Jenkins. I do however see it in the list of installed plugins.

It should appear. if there's no such section, probably there's a data corruption in the target output. Try "mvn clean" and then run the hpi:run command again.

Best regards,
Oleg

2015-07-29 2:18 GMT+03:00 Karan Anand <kan...@microsoft.com>:

Hello Oleg, Ryan,

 

First, thanks for doing a great job with the custom-tools-plugin! (And apologies for the long email)

 

We are trying to use this plugin for our organization, and it would work almost perfectly for our needs.

 

The only things we are looking to have are:

-          Support for Nuget packages (which is basically just another compressed file)

-          Support versioning of tools (maybe as simple as reading it from name of file)

 

In order to add these features, we would like to contribute to source code of the plugin.

 

For this, I have sync’ed the github repository, and started to play around.

 

I am really new to plugin development (but familiar with maven & java world), which is probably why I am running into issues while trying to run the project.

Here is what I did:

1.       Sync repository

2.       Install maven

3.       Run ‘mvn install’ -> I see most of the tests erroring out (logs attached)

4.       Alternatively, I tried to run Jenkins using ‘mvn hpi:run’ -> In this case I am not able to see the custom tool section show up when I try to configure Jenkins. I do however see it in the list of installed plugins.

 

I am sure I am missing something / doing something wrong. Do you have any pointers as to how to solve these problems?

I would like to make some local changes, test them, and eventually submit a pull request.

 

Apologies if this is not the right way to approach, please let me know if there is a better way to reach out.

 

Thanks again!

 

-Karan Anand

 


illnino Ho

unread,
Aug 1, 2016, 6:08:09 AM8/1/16
to Jenkins Developers, kan...@microsoft.com, ryan.c...@gmail.com
Hi, guys

I have the same problems. The custom tool plugin doesnt show up. Any solution? May I know where should I run this?
Reply all
Reply to author
Forward
0 new messages