Build status vs. checks on jenkins.io

70 views
Skip to first unread message

Ullrich Hafner

unread,
Nov 23, 2020, 3:56:04 AM11/23/20
to Jenkins Developers
Since we have successfully integrated the GitHub checks in buildPlugin for quite a while: would it make sense to disable the old build status results on https://ci.jenkins.io?

Currently I get two different results from Jenkins (and the old one is wrong since it assumes that status UNSTABLE means that there are test failures):

1) Jenkins
2) continuous-integration/jenkins/pr-merge — This commit has test failures





Xiong Kezhi

unread,
Nov 23, 2020, 4:41:05 AM11/23/20
to Jenkins Developers
I'm not sure if this is a situation we need to take care of:

The branch source plugin may publish two builds including the merge build and branch build (if a pr is opened long after the branch is pushed?) to the PR, but the github-checks will publish only one since we used the build listener (the one for the branch will be replaced later if you file a PR based on that branch).

Jesse Glick

unread,
Nov 23, 2020, 9:59:38 AM11/23/20
to Jenkins Dev
On Mon, Nov 23, 2020 at 3:56 AM Ullrich Hafner <ullrich...@gmail.com> wrote:
> Since we have successfully integrated the GitHub checks in buildPlugin for quite a while: would it make sense to disable the old build status results on https://ci.jenkins.io?

I think it would make sense.

If this happens, please post an announcement. At least JEP-229 would
need a minor change:
https://github.com/jglick/verify-ci-status-action/issues/1

Jesse Glick

unread,
Jan 6, 2021, 4:55:26 PM1/6/21
to Jenkins Dev
I filed INFRA-2866 to track.

timja...@gmail.com

unread,
Jan 9, 2021, 4:13:43 AM1/9/21
to Jenkins Developers
Done

On Wednesday, 6 January 2021 at 21:55:26 UTC Jesse Glick wrote:
I filed INFRA-2866 to track.

Ullrich Hafner

unread,
Feb 22, 2021, 4:23:10 PM2/22/21
to Jenkins Developers
Currently a successful incremental deployment is shown with a separate GitHub checks output, this is very handy to directly jump to the new release. Would it make sense to add a negative (or neutral) check in case something went wrong? E.g., if the PR is not in sync with the base branch then the check result is completely missing. In such a case one needs to dig into the console log just to see that the branch is not in sync.
> --
> You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/CANfRfr3_S9iu2-BSq6YvwKjWM_xegTJazVJC%3D9w_UagP68U21w%40mail.gmail.com.

Jesse Glick

unread,
Feb 22, 2021, 4:33:41 PM2/22/21
to Jenkins Dev
On Mon, Feb 22, 2021 at 4:23 PM Ullrich Hafner <ullrich...@gmail.com> wrote:
Would it make sense to add a negative (or neutral) check in case something [with Incrementals] went wrong?

Reply all
Reply to author
Forward
0 new messages