Drop eddsa from trilead

[Michael Kriese]

Hi,

i think the `net.i2p.crypto:eddsa` dependency can gbe removed from the `trilead-ssh2` library because it depends on java 17.

Java has native support for EDDSA since v15.

Jenkins will depend on Java 21 soon too.

Then `eddsa-api` plugin can be dropped from `trilead-api` plugin too.

WDYT?

Regards

Michael

[Basil Crow]

On Thu, Apr 3, 2025 at 1:32 AM 'Michael Kriese' via Jenkins Developers
<jenkin...@googlegroups.com> wrote:
> WDYT?

Sounds good in theory. In practice, I gave it a shot with Mina and
found the Java Platform APIs insufficient, as described in
https://github.com/apache/mina-sshd/issues/585#issuecomment-2742332155.
It is possible this could be done with more time and effort, or with
an enhancement to OpenJDK. I welcome anyone to give it a try for
Trilead.

[Michael Kriese]

Yes, i also found that trilead is only used by ssh-slaves plugin. so it's probably better work on ssh-slaves to use mina instead of trilead, so trilead and eddsa plugins can be dropped (and uninstalled from my instance)

[Ivan Fernandez Calvo]

I made a replacement of the trilead three years ago. It works, but I found an issue with idle connections after ~5; they disconnect. I did not see the cause at the time. Keeping the channel with traffic does not disconnect the channel. I have to update that branch with the latest changes to Java 17 and the latest version of Apache Mina 

https://github.com/kuisathaverat/ssh-agents-plugin/tree/apache_mina

[Basil Crow]

Note that even if the SSH Build Agents plugin were migrated from
Trilead to MINA, JENKINS-75498 needs to be implemented to migrate from
EdDSA-Java to Bouncy Castle in MINA at runtime in cases where the
EdDSA-Java is installed (for example, as a required dependency of the
Subversion or SSH Server plugins).

[kuisathaverat]

I just rebase my changes to the latest core and Apache Mina API plugin that uses 2.15.0 Apache Mina ssh. After fixing some changes and refactors on packages, I made the same test I did three years ago. The new version can keep a stable connection for more than 10 minutes, and the library reports more info about the connection, so it is easy to debug errors. I will work in the following weeks to finish the launcher and all the stuff related to it. If everything goes fine, I will release a beta launcher that will replace the older one as soon as we are confident with the result.

https://github.com/jenkinsci/ssh-agents-plugin/pull/570

--
You received this message because you are subscribed to a topic in the Google Groups "Jenkins Developers" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/jenkinsci-dev/74P64-_6fJM/unsubscribe.
To unsubscribe from this group and all its topics, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/jenkinsci-dev/CAFwNDjpCNiRrFqt1WjBv%2BVO%2BVjDyUxQtmsnQBa6Bs1qitqUveQ%40mail.gmail.com.

--

Un Saludo

Iván Fernández Calvo