Table-to-div fix pointers please?

[Alan Dennis]

Hi,

I'm having a quick look at trying to fix the Ivy Plugin that got broken by the "Tables-to-Divs" changes.

I've had a quick grep through the source for "<tr>" which finds just one table, here...

https://github.com/jenkinsci/ivy-plugin/blob/master/src/main/resources/hudson/ivy/IvyModuleSetBuild/main.jelly#L58

... which I'm assuming is what breaks it? (https://issues.jenkins.io/browse/JENKINS-67449)

Could some kind person, with knowledge of the "tables-to-divs" changes, give me a clue about what the fix needs to look like please?

Maybe point me at some similar example changes I could get some cluses from?

Many Thanks!

(And Merry Christmas btw 😊)

Alan.

[Mark Waite]

On Friday, December 24, 2021 at 5:46:26 AM UTC-7 Alan wrote:

Hi,

I'm having a quick look at trying to fix the Ivy Plugin that got broken by the "Tables-to-Divs" changes.

I've had a quick grep through the source for "<tr>" which finds just one table, here...

https://github.com/jenkinsci/ivy-plugin/blob/master/src/main/resources/hudson/ivy/IvyModuleSetBuild/main.jelly#L58

... which I'm assuming is what breaks it? (https://issues.jenkins.io/browse/JENKINS-67449)

Could some kind person, with knowledge of the "tables-to-divs" changes, give me a clue about what the fix needs to look like please?

Thanks for your willingness to investigate and fix the issue!

See https://www.jenkins.io/doc/developer/views/table-to-div-migration/#maintaining-support-for-tables-and-div-layout for a description of the types of changes usually made to resolve tables to divs issues.

Alternately, you could consider modernizing the plugin so that it requires Jenkins 2.289.1 or newer as its minimum Jenkins version and then the table layout could be replaced by divs without any conditional logic.

If you're willing to spend the extra effort to modernize the plugin, a series of modernization steps are described in the Google Doc that has evolved from a workshop presented at DevOps World 2021.

Mark Waite

[Alan Dennis]

Hey, Thanks Mark.

That was a good pointer. I'd seen that page, but hadn't realised that was what I needed. I added some code based on the multiple-scms-plugin example, built the plugin. No difference ☹

I had another dig around though and came up with this: https://github.com/jenkinsci/ivy-plugin/blob/master/src/main/resources/hudson/ivy/IvyModuleSet/configure-entries.jelly#L94

Looking at https://github.com/jenkinsci/matrix-project-plugin/blob/master/src/main/resources/hudson/matrix/MatrixProject/configure-entries.jelly#L95 - that uses config-publishers2?

Is it really as simple as just adding a "2"?

Yes, apparently it is - that seems to work! 😀

On that triumph, that's enough work for a Christmas Eve!

Cheers,

Alan.