Looking to contribute to official Discard Old Build plugin distribution

[Benjamin Beggs]

Hi,

I'm hoping to update the Discard Old Build plugin (https://plugins.jenkins.io/discard-old-build) to expand its feature set and improve general reliability/stability. I will be updating the code to allow for more sophisticated discard conditions. For e.g. allowing a user to request that builds older than N days are discarded but at least the M most recent builds are kept no matter their age. How do I go about having my contributions added to the distribution provided by the Jenkins plugin server?

Best,

Benjamin

[Jeff]

HI Benjamin

You should be able to just submit a PR to the repo, and one of the maintainers should review it and merge it if they feel it's a good addition. I'd suggest smaller PRs, and if appropriate you can discuss individual proposed changes here, or you could contact the maintainers directly.

Keep in mind that most plugin maintainers are volunteers, and it's easy for them to miss a PR, so don't be discouraged if you have trouble getting traction at first. I've found direct emails to work well when my PRs aren't reviewed within a few days.

Best,

Jeff

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/d813ec6c-521b-4b10-ab5c-388bad9ddbce%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Oleg Nenashev]

Hi all,

Just to add some context, we had a Advanced Build Discarder Strategy project idea in GSoC this year: https://jenkins.io/projects/gsoc/2019/project-ideas/advanced-build-discard-strategy-plugin/

We got a number of applications, but unfortunately we were not able to accept a project due to the limited number of slots.

The referenced plugin was in the scope of the project, and IIUC Nisarg is interested to continue working on the project. So you guys may want to coordinate the effort in this thread.

Best regards,

Oleg

On Wednesday, May 8, 2019 at 5:30:38 PM UTC+2, Jeff wrote:

HI Benjamin

You should be able to just submit a PR to the repo, and one of the maintainers should review it and merge it if they feel it's a good addition. I'd suggest smaller PRs, and if appropriate you can discuss individual proposed changes here, or you could contact the maintainers directly.

Keep in mind that most plugin maintainers are volunteers, and it's easy for them to miss a PR, so don't be discouraged if you have trouble getting traction at first. I've found direct emails to work well when my PRs aren't reviewed within a few days.

Best,

Jeff

On Wed, May 8, 2019 at 8:12 AM Benjamin Beggs <benjam...@outlook.com> wrote:

Hi,

I'm hoping to update the Discard Old Build plugin (https://plugins.jenkins.io/discard-old-build) to expand its feature set and improve general reliability/stability. I will be updating the code to allow for more sophisticated discard conditions. For e.g. allowing a user to request that builds older than N days are discarded but at least the M most recent builds are kept no matter their age. How do I go about having my contributions added to the distribution provided by the Jenkins plugin server?

Best,

Benjamin

--
You received this message because you are subscribed to the Google Groups "Jenkins Developers" group.

To unsubscribe from this group and stop receiving emails from it, send an email to jenkin...@googlegroups.com.

[Oleg Nenashev]

+ Nisarg

You received this message because you are subscribed to a topic in the Google Groups "Jenkins Developers" group.
To unsubscribe from this topic, visit https://groups.google.com/d/topic/jenkinsci-dev/5uFsybui5yw/unsubscribe.
To unsubscribe from this group and all its topics, send an email to jenkinsci-de...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jenkinsci-dev/20c97780-01ff-4057-8571-c0c6098a20cf%40googlegroups.com.

[Nisarg Shah]

Hi,

I would like to work and co-ordinate with Benjamin for working on Advanced Build Discarder Plugin and adding few features which can be helpful to community.

Please let me know from where can we start and where discussion would take place? I would be happy to contribute. And Thank you Oleg Sir for giving me this opportunity.

Thanks and Regards,

Nisarg Shah

[Benjamin Beggs]

Hi Nisarg,

I'm not planning on implementing much to the scope of the GSoC document, mostly just the aforementioned change I describe in my example. The logistics of planning a collaboration may take too long for the kind of work I'm looking to do on this for now.

Best,

Benjamin

On Thursday, May 9, 2019 at 7:22:27 AM UTC-4, Nisarg Shah wrote:

Hi,

I would like to work and co-ordinate with Benjamin for working on Advanced Build Discarder Plugin and adding few features which can be helpful to community.

Please let me know from where can we start and where discussion would take place? I would be happy to contribute. And Thank you Oleg Sir for giving me this opportunity.

Thanks and Regards,

Nisarg Shah

On Thu, 9 May 2019 at 16:44, Oleg Nenashev <o.v.n...@gmail.com> wrote:

+ Nisarg

To unsubscribe from this group and all its topics, send an email to jenkin...@googlegroups.com.

[Nisarg Shah]

Okay. If you want, we can add some more functionalities similar to your use case. I have done some study related that. I am sharing my GSoC Proposal, if you are interested we can work together and add functionalities. Else we can just add the use case you mentioned in the earlier discussion. So let me know your thoughts and if agreed than we can start work together(on any feature).

Thanks and Regards,

Nisarg Shah

[Benjamin Beggs]

I appreciate the desire to work on this with me but at the moment I think it would be faster for me to implement this feature myself. I may get in touch if it turns out to be more work than I expect, though. :)

Best,

Benjamin

[Nisarg Shah]

Okay Sure.