Adoption of dtkit-plugin

70 views
Skip to first unread message

Nikolas Falco

unread,
Mar 3, 2019, 11:36:09 AM3/3/19
to Jenkins Developers
Hi, xunit-plugin is developed on top the dtkit-plugin libraries. dtkit-plugin was develop by the same author of xunit plugin.
I need to update the library that dtkit-plugin use and to adapt the code to use new APIs.

In discussion to adopt xunit-plugin, Jesse Glick suggested to transform the dtkit-plugin in a API plugin (https://groups.google.com/d/msg/jenkinsci-dev/o8GtAiXFf7M/uX-5AhgxAgAJ) this will allow to disarm all inherited maven tricks to include dtkit dependencies here (https://github.com/jenkinsci/xunit-plugin/blob/6186bda0d95e1fc36b3aba621fb6649dc966b292/pom.xml#L249).

Falco Nikolas

Nikolas Falco

unread,
Mar 9, 2019, 9:29:25 AM3/9/19
to Jenkins Developers
Any comments? Any news? Any doubts?

Oleg Nenashev

unread,
Mar 10, 2019, 5:49:24 AM3/10/19
to Jenkins Developers
The ownership transfer looks good to me.
I am also fine with dkit as API plugin, the current approach is definitely a subject for improvement

BR, Oleg

Nikolas Falco

unread,
Mar 10, 2019, 5:28:04 PM3/10/19
to Jenkins Developers
PR for infra repository available here:
https://github.com/jenkins-infra/repository-permissions-updater/pull/1058

Feel free to approve and merge.

Thanks in advance!

Nikolas Falco

unread,
Mar 20, 2019, 6:26:27 AM3/20/19
to Jenkins Developers
Guys any chance to finalize this? I have pending work blocked because I can not push on repositories

Nikolas Falco

unread,
Apr 8, 2019, 4:22:27 AM4/8/19
to Jenkins Developers
The PR to manage permissions for Artifactory has been merged but I do not have yet permissions to push to github repository jenkinsci/dtkit-plugin

Anyone can help?

Oleg Nenashev

unread,
Apr 8, 2019, 10:10:58 AM4/8/19
to Jenkins Developers
Hi, 

It should be fixed now. Merging a PR is not enough nowadays, a manual ChatOps command is required

Best regards,
Oleg

Nikolas Falco

unread,
Apr 9, 2019, 3:45:06 AM4/9/19
to Jenkins Developers
No push is denied for jenkinsci/libdtkit repository

"remote: Permission to jenkinsci/libdtkit.git denied to nfalco79."

The same for jenkinsci/dtkit-plugin

Nikolas Falco

unread,
Apr 10, 2019, 11:10:59 AM4/10/19
to Jenkins Developers
No write access yet


Il giorno lunedì 8 aprile 2019 16:10:58 UTC+2, Oleg Nenashev ha scritto:

Oleg Nenashev

unread,
Apr 11, 2019, 7:05:42 PM4/11/19
to Jenkins Developers
OK, it should be fixed now.
It seems I messed up the original ChatOps requests
Reply all
Reply to author
Forward
0 new messages