JedisPubSub and BinaryJedisPubSub PING don't support optional argument

Sarah

unread,

Sep 28, 2020, 10:24:52 AM9/28/20

to Jedis

According to the Redis docs at https://redis.io/commands/ping PING takes an optional message, and indeed the Jedis client does have both overloads with and without the message parameter. The overload with message is missing from JedisPubSub and BinaryJedisPubSub.

Relevant issues:

I've created a PR for this and would love some reviews: https://github.com/xetorthio/jedis/pull/2254

Sarah

unread,

Oct 29, 2020, 4:08:08 PM10/29/20

to Jedis

Can this commit be merged?

https://github.com/redis/jedis/pull/2254

Sazzadul Hoque

unread,

Oct 30, 2020, 2:45:51 AM10/30/20

to jedis...@googlegroups.com

Hopefully, it will be.

--
You received this message because you are subscribed to the Google Groups "Jedis" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jedis_redis...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jedis_redis/08965241-1330-4676-aa29-d753c5117ea8n%40googlegroups.com.

Sarah

unread,

Nov 17, 2020, 12:27:22 PM11/17/20

to Jedis

Is there anything I need to do to get this merged or get someone else to look at it?

Reply all

Reply to author

Forward