Issue 56 in jayrock: Make Jayrock meet the error requirements of JSON-RPC 2.0

[jay...@googlecode.com]

Status: New
Owner: ----
Labels: Type-Enhancement Priority-Medium

New issue 56 by jeam...@gmail.com: Make Jayrock meet the error requirements
of JSON-RPC 2.0
http://code.google.com/p/jayrock/issues/detail?id=56

Given that JSON-RPC does not define the error object, but JSON-RPC 2.0
does, it would be nice or interesting to encapsulate all exceptions thrown
by an application with a custom exception, as to make the JsonRpcError
class return a correct JSON-RPC 2.0 error object.

e.g. as for now Jayrock returns an object like { "name", "error", "errors"
} whilst JSON-RPC 2.0 specification defines the error object as
{ "code", "message", "data" }. I have edited somewhat the code of the
application, and found that you can perfectly define custom Exceptions with
a code (and still treat basic Exceptions with a custom "unknown Exception"
code). This way you can offer a JsonException class to the user, which
could be inherited and the error code changed or something.

I marked this as an enhancement because the current error object meets
JSON-RPC 1.0 requirements.

--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[jay...@googlecode.com]

Updates:
Status: Accepted
Labels: -Priority-Medium Priority-Low Component-JSON-RPC

Comment #1 on issue 56 by azizatif: Make Jayrock meet the error

requirements of JSON-RPC 2.0
http://code.google.com/p/jayrock/issues/detail?id=56

(No comment was entered for this change.)

[jay...@googlecode.com]

Comment #2 on issue 56 by RolfanRa...@gmail.com: Make Jayrock meet the

error requirements of JSON-RPC 2.0

https://code.google.com/p/jayrock/issues/detail?id=56

Here's an initial patch to resolve this issue. Please review it and make
sure its good for inclusion

Attachments:
jayrock_76_to_77.diff 3.7 KB

[jay...@googlecode.com]

Comment #3 on issue 56 by RolfanRa...@gmail.com: Make Jayrock meet the

error requirements of JSON-RPC 2.0
https://code.google.com/p/jayrock/issues/detail?id=56

Uhm, dude? what's up with this?

[jay...@googlecode.com]

Comment #4 on issue 56 by azizatif: Make Jayrock meet the error

requirements of JSON-RPC 2.0
https://code.google.com/p/jayrock/issues/detail?id=56

@RolfanRagnorak Since Google has been so kind to shut down their project
hosting service[1] (instead of, say, just freezing it), I'm spending a lot
time migrating my projects as opposed to making actual progress on them.
That's what's up.

[1]:
http://google-opensource.blogspot.ch/2015/03/farewell-to-google-code.html

[jay...@googlecode.com]

Comment #5 on issue 56 by azizatif: Make Jayrock meet the error

requirements of JSON-RPC 2.0
https://code.google.com/p/jayrock/issues/detail?id=56

@RolfanRagnorak I finally got round to reviewing your patch. Seems to me
that @jeamfry is looking for JSON-RPC 2.0 compliance on the server end for
reported errors whereas your patch addresses the issue on the client side.

[jay...@googlecode.com]

Comment #6 on issue 56 by azizatif: Make Jayrock meet the error

requirements of JSON-RPC 2.0
https://code.google.com/p/jayrock/issues/detail?id=56

This issue has been migrated to:
https://github.com/atifaziz/Jayrock/issues/56
The conversation continues there.
DO NOT post any further comments to the issue tracker on Google Code as it
is shutting down.
You can also just subscribe to the issue on GitHub to receive notifications
of any further development.