Javasimon improvements

[alexej vlasov]

Hello!

I have downloaded javasimon and was very excited. For our purposes it would be nice to made some additional features:

- logarithmic buckets (buckets whith non linear ranges. for example 0-1,1-2,2-4,4-8,8-16 ans so on). 

- call tree statistics (not only last call)

- some visual improvements.

This features can be realized just in our project, but i think this features may be useful for another users, and this feature may be realized more elegant with small changes of javasimon code. My question is: is it possible to send patch for javasimon for commit purpose (of course with review) and new code for this features?

[Richard Richter]

Hi Alexej

Thanks for using Java Simon. Of course you can contribute with a patch
and if it's not completely off we mostly use such patches. It would be
good to demo your feature in the build in Jetty application (part of
the console/embedded) and/or as an example in example module. Tests
are always nice benefit too. Depending on how much work it is for you,
start with something smaller and let me check if we want it or not, so
I don't feel bad in case I reject 10k lines of code or something. ;-)

Cheers

Virgo

> --
> You received this message because you are subscribed to the Google Groups
> "javasimon" group.
> To view this discussion on the web visit
> https://groups.google.com/d/msg/javasimon/-/DObg3I1VaYEJ.
> To post to this group, send email to java...@googlegroups.com.
> To unsubscribe from this group, send email to
> javasimon+...@googlegroups.com.
> For more options, visit this group at
> http://groups.google.com/group/javasimon?hl=en.

[Gérald]

Hi all,

I am impatient to see your improvements:
1) About logarithmic buckets in Quantiles, I thought about it while designing it but abandonned the idea because having larger buckets at the end means that 90%, 95% percentiles will be less precise (they are already an approximation). What's your opinion? I guess that the Buckets class needs to be abstracted, does it? Richard> It's fairly easy to unit test it, as most of the code is in the callback, it should work without modifying the UI.
2) About call tree statistics, I also made an attempt by keeping the last N call trees (using a ring buffer) and then abandonned the idea because logging call trees is more effective in post mortem analysis. How did you do it? Do you merge call trees?

Gérald

[alexej vlasov]

1. I have sent patch for exponential (non logarithmic :-) ) buckets to virgo. I think that Buckets class should be abstract.

2. I don't have implementation of this, so i can't discuss. I will try on this or next week. 

воскресенье, 21 октября 2012 г., 17:26:19 UTC+4 пользователь Gérald написал: