Spring configuration for plugins

[Jürgen Schmied]

Hi!

I try to configure the plugins from context.xml:
----
    <bean id="simonManager" class="org.javasimon.spring.ManagerFactoryBean">
        <property name="callbacks">
            <list>
                <bean class="org.javasimon.callback.timeline.TimelineCallback">
                    <constructor-arg index="0" value="10" />
                    <constructor-arg index="1" value="60000" />
                </bean>
                <bean class="org.javasimon.callback.calltree.CallTreeCallback">
                    <constructor-arg value="200" />
                </bean>
            </list>
        </property>
    </bean>

    <bean id="monitoringInterceptor" class="org.javasimon.spring.MonitoringInterceptor" >
        <constructor-arg ref="simonManager"/>
    </bean>

    <aop:config>
        <aop:pointcut id="allRMIServicePointcut" expression="execution(* xxxxxxx.*.*Service.*(..))" />
        <aop:advisor advice-ref="monitoringInterceptor" pointcut-ref="allRMIServicePointcut" />
    </aop:config>
---
    <servlet>
        <servlet-name>SimonConsoleServlet</servlet-name>
        <servlet-class>org.javasimon.console.SimonConsoleServlet</servlet-class>
        <init-param>
            <param-name>url-prefix</param-name>
            <param-value>/javasimon-console</param-value>
        </init-param>
        <init-param>
            <param-name>plugin-classes</param-name>
            <param-value>org.javasimon.console.plugin.TimelineDetailPlugin,org.javasimon.console.plugin.CallTreeDetailPlugin</param-value>
        </init-param>
    </servlet>
----

everything works, but the Timeline and Calltree are not shown in the webconsole. Do I miss something?

Thanks!

Juergen

[Gérald]

You need to register the corresponding callbacks in the simon manager:

// TimelineCallback 10 buckets of 1 minute each
SimonManager.callback().addCallback(new TimelineCallback(10, 60000L));
// CallTreeCallback
SimonManager.callback().addCallback(new CallTreeCallback(50));

Gérald

[Jürgen Schmied]

> You need to register the corresponding callbacks in the simon manager

I think the bean configuration does exactly this: it creates the two callback objects and initializes the ManagerFactoryBean with them.
Additionally it gives the ManagerFactoryBean to MonitoringInterceptor. The spring log shows the Objects are created.

Where sholud I put the SimonManager.callback().addCallback instead?

Juergen

[Gérald]

You're right, your callback declaration is alright, I missed that part of your code at first read.
Can you see your Simons in the web console?
   No -> the console servlet is not plugged on the same Simon manager instance.
   Yes -> check whether JavaScript resources are properly loaded using FireFox+FireBug or Chrome Dev Tools and the network panel. Are there 404 errors on JavaScript loading?

Gérald

[Jürgen Schmied]

Yes I see the Simons and thair values everything works but the plugins.
The *.js for the plugins is not loaded (net event tried, no 404).

Can I enable debug messages somehow?

--
You received this message because you are subscribed to the Google Groups "javasimon" group.
To unsubscribe from this group and stop receiving emails from it, send an email to javasimon+...@googlegroups.com.
To post to this group, send email to java...@googlegroups.com.
Visit this group at http://groups.google.com/group/javasimon.
For more options, visit https://groups.google.com/d/optout.

[Jürgen Schmied]

> the console servlet is not plugged on the same Simon manager instance.

How can i check if there is more than one Simon manager instance?

Thanks!

juergen

[Gérald]

What returns the HTTP request to /data/plugins.json?

What version are you using?

We should add log to tell which plugins are effectively loaded.

Gerald

[Gérald]

Don't look further, there is a bug in the Servlet code.
The fix is on the way.

Gérald

[Richard Richter]

Hello

I owe the project (and Gerald) some release, so after this fix we'll
release 4.0.1 before Christmas. :-)

Cheers

Virgo

[Gérald]

Bug fixed

https://github.com/gquintana/javasimon/commit/1d20c4623dc70dfc58b52b710d02b7f0f8b9fb78

Gérald

Le mercredi 17 décembre 2014 10:29:48 UTC+1, Virgo47 a écrit :

Hello

I owe the project (and Gerald) some release, so after this fix we'll
release 4.0.1 before Christmas. :-)

Cheers

Virgo

On Wed, Dec 17, 2014 at 10:24 AM, Gérald <gerald....@gmail.com> wrote:
> Don't look further, there is a bug in the Servlet code.
> The fix is on the way.
>
> Gérald
>
> Le mercredi 17 décembre 2014 09:30:33 UTC+1, Gérald a écrit :
>>
>> What returns the HTTP request to /data/plugins.json?
>> What version are you using?
>>
>> We should add log to tell which plugins are effectively loaded.
>>
>> Gerald
>>
>> Le mardi 16 décembre 2014 22:33:19 UTC+1, Jürgen Schmied a écrit :
>>>
>>> > the console servlet is not plugged on the same Simon manager instance.
>>> How can i check if there is more than one Simon manager instance?
>>>
>>> Thanks!
>>>
>>> juergen
>>>
>>>
> --
> You received this message because you are subscribed to the Google Groups
> "javasimon" group.
> To unsubscribe from this group and stop receiving emails from it, send an

> email to javasimon+unsubscribe@googlegroups.com.

[Jürgen Schmied]

Version 3.5.2 (still use Java 6)
I debugged into SimonConsoleServlet.init(). The plugin classes are loaded by the frontend (I use embedded).

data/plugins.json gives [] back.

The Webapp doesn't try to load javasimon-timelinePlugin.js.

The ManagerFactoryBean.getObject() registers the callbacks too.

During Runtime the CompositeCallback calls both registered callbacks on all actions.

But I noticed: there are 2 instances of SimonConsolePluginManager. One instance gets the addPlugins() and the second instance is asked for the registed plugins ...

How can that be?

[Jürgen Schmied]

Is there any possibility to fix the 3.x branch? We - and possibly other people are using still Java6 ...

Thanks!

[Richard Richter]

Jurgen

I understand your pain, I have been using Java 6 quite recently as
well. But personally I don't support 3.x branch anymore. If you want,
you can fork it, do the necessary changes and create pull request. I'd
merge it and release 3.5.x bugfix release then, I can handle that
much. :-)

Cheers

Virgo

[Gérald]

@Richard There's no 3.5.x tag/branch in GitHub

@Jurgen The console and the spring config  use the same Simon manager, else you wouldn't have any Simon data in the console. What you're saying is really strange, the plugin manager is a final attribute of SimonConsoleRequestProcessor.

Gérald

[Richard Richter]

I meant this branch: https://github.com/virgo47/javasimon/tree/version-3.5

[Richard Richter]

Hi Jurgen

Are you allowed to test SNAPSHOT too? I backported a couple more of
older fixes that are only in master and if you can give it a twist
before I release non-SNAPSHOT 3.5.3, it would be cool.

BTW: I dropped jdbc41 from version-3.5 branch, it doesn't make sense
for people stuck on Java 6 anyway.

Virgo

[Richard Richter]

Hi

To let you know:
- Snapshot of 3.5.3 is up, e.g. console webapp here:
https://oss.sonatype.org/content/repositories/snapshots/org/javasimon/javasimon-console-webapp/3.5.3-SNAPSHOT/
(that is Maven Central snapshot repo)
- Release version of 4.0.1 is also available.

Virgo