how to add new serializer to the benchmark

[Pres]

Hi there,

I created a new general purpose java object serializer centered around sun.misc.Unsafe.
How can I add a respective benchmark for it into the main stream version?

http://www.sockali.net/obser/

PS: Also, what is better for hosting that project? git-hub or Google-Code ?

Cheers,
Pres

[Tatu Saloranta]

On Wed, Feb 6, 2013 at 3:17 PM, Pres <psoc...@gmail.com> wrote:
> Hi there,
>
> I created a new general purpose java object serializer centered around
> sun.misc.Unsafe.
> How can I add a respective benchmark for it into the main stream version?

Check out source code, make modifications similar to how other codecs
work (there are plenty).

>
> http://www.sockali.net/obser/
>
> PS: Also, what is better for hosting that project? git-hub or Google-Code ?

Github.

-+ Tatu +-

>
> Cheers,
> Pres
>
> --
> You received this message because you are subscribed to the Google Groups
> "java-serialization-benchmarking" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to java-serialization-be...@googlegroups.com.
> To post to this group, send email to
> java-serializat...@googlegroups.com.
> Visit this group at
> http://groups.google.com/group/java-serialization-benchmarking?hl=en.
> For more options, visit https://groups.google.com/groups/opt_out.
>
>

[Pres]

Hi Tatu,

I've got the tpc project compiled and working locally (except some aspects).
What is the next step?
Sorry, never really worked with GIT, everything seems a bit strange to me...

Regards,
Pres

On Thursday, 7 February 2013 02:17:47 UTC+1, cowtowncoder wrote:

On Wed, Feb 6, 2013 at 3:17 PM, Pres <psoc...@gmail.com> wrote:
> Hi there,
>
> I created a new general purpose java object serializer centered around
> sun.misc.Unsafe.
> How can I add a respective benchmark for it into the main stream version?

Check out source code, make modifications similar to how other codecs
work (there are plenty).

>
> http://www.sockali.net/obser/
>
> PS: Also, what is better for hosting that project? git-hub or Google-Code ?

Github.

-+ Tatu +-

>
> Cheers,
> Pres
>
> --
> You received this message because you are subscribed to the Google Groups
> "java-serialization-benchmarking" group.
> To unsubscribe from this group and stop receiving emails from it, send an

> email to java-serialization-benchmarking+unsubscribe@googlegroups.com.

> To post to this group, send email to

> java-serialization-benchm...@googlegroups.com.

[Tatu Saloranta]

On Tue, Feb 12, 2013 at 12:01 PM, Pres <psoc...@gmail.com> wrote:
> Hi Tatu,
>
> I've got the tpc project compiled and working locally (except some aspects).
> What is the next step?

Usually the way to do this is to fork the project (which creates your
own copy basically), do modifications, send a pull request. Then one
of maintainers can do a single-click accept to get changes to pulled
in.

Alternatively we can do manual patch, if you use 'git diff'. But
fork+pull request is the usual "github way".

-+ Tatu +-

[Pressenna]

I used egit to get a local copy.
Do I have to fork and publish the changes on a public git server in order to make a pull request?
If so, can we go the diff approach ?

-PSK

-+ Tatu +-

--
You received this message because you are subscribed to the Google Groups "java-serialization-benchmarking" group.

To unsubscribe from this group and stop receiving emails from it, send an email to java-serialization-be...@googlegroups.com.
To post to this group, send email to java-serializat...@googlegroups.com.

[Tatu Saloranta]

On Tue, Feb 12, 2013 at 2:07 PM, Pressenna <psoc...@gmail.com> wrote:
> I used egit to get a local copy.
> Do I have to fork and publish the changes on a public git server in order to
> make a pull request?

Yes I think so.

> If so, can we go the diff approach ?

We can do that now sure.

-+ Tatu +-

[Pres]

Hi Tatu,

attached is the patch and the additional lib, which somehow was not embedded into the patch....
Let me know if you encounter any trouble.

Cheers,
Pres

>> email to java-serialization-benchmarking+unsubscribe@googlegroups.com.

>> To post to this group, send email to

>> java-serialization-benchm...@googlegroups.com.

>> Visit this group at
>> http://groups.google.com/group/java-serialization-benchmarking?hl=en.
>> For more options, visit https://groups.google.com/groups/opt_out.
>>
>>
>
> --
> You received this message because you are subscribed to the Google Groups
> "java-serialization-benchmarking" group.
> To unsubscribe from this group and stop receiving emails from it, send an

> email to java-serialization-benchmarking+unsubscribe@googlegroups.com.

> To post to this group, send email to

> java-serialization-benchm...@googlegroups.com.

[Tatu Saloranta]

Merged patch in. Unfortunately I don't have working make on my machine
(stupid Apple requiring XCode installation), so I can't verify it
builds, but I assume it should be ok.

-+ Tatu +-

>> >> email to java-serialization-be...@googlegroups.com.

>> >> To post to this group, send email to

>> >> java-serializat...@googlegroups.com.

>> >> Visit this group at
>> >> http://groups.google.com/group/java-serialization-benchmarking?hl=en.
>> >> For more options, visit https://groups.google.com/groups/opt_out.
>> >>
>> >>
>> >
>> > --
>> > You received this message because you are subscribed to the Google
>> > Groups
>> > "java-serialization-benchmarking" group.
>> > To unsubscribe from this group and stop receiving emails from it, send
>> > an

>> > email to java-serialization-be...@googlegroups.com.

>> > To post to this group, send email to

>> > java-serializat...@googlegroups.com.

>> > Visit this group at
>> > http://groups.google.com/group/java-serialization-benchmarking?hl=en.
>> > For more options, visit https://groups.google.com/groups/opt_out.
>> >
>> >
>
> --
> You received this message because you are subscribed to the Google Groups
> "java-serialization-benchmarking" group.
> To unsubscribe from this group and stop receiving emails from it, send an

> email to java-serialization-be...@googlegroups.com.

> To post to this group, send email to

> java-serializat...@googlegroups.com.

[Pres]

Hi Tatu,

attaches is an ANT build file and a launcher script.
Can you also add these to the repository?

Regards,
Pres

>> >> email to java-serialization-benchmarking+unsubscribe@googlegroups.com.

>> >> To post to this group, send email to

>> >> java-serialization-benchm...@googlegroups.com.

>> >> Visit this group at
>> >> http://groups.google.com/group/java-serialization-benchmarking?hl=en.
>> >> For more options, visit https://groups.google.com/groups/opt_out.
>> >>
>> >>
>> >
>> > --
>> > You received this message because you are subscribed to the Google
>> > Groups
>> > "java-serialization-benchmarking" group.
>> > To unsubscribe from this group and stop receiving emails from it, send
>> > an

>> > email to java-serialization-benchmarking+unsubscribe@googlegroups.com.

>> > To post to this group, send email to

>> > java-serialization-benchm...@googlegroups.com.

>> > Visit this group at
>> > http://groups.google.com/group/java-serialization-benchmarking?hl=en.
>> > For more options, visit https://groups.google.com/groups/opt_out.
>> >
>> >
>
> --
> You received this message because you are subscribed to the Google Groups
> "java-serialization-benchmarking" group.
> To unsubscribe from this group and stop receiving emails from it, send an

> email to java-serialization-benchmarking+unsubscribe@googlegroups.com.

> To post to this group, send email to

> java-serialization-benchm...@googlegroups.com.

[Tatu Saloranta]

We used to have something else earlier, and then it was converted to
Make due to preferences of author (I forget which of us it was). So I
think I would like to defer this to others.
As to launcher, there is already 'run' isn't there?

-+ Tatu +-

>> >> >> java-serialization-be...@googlegroups.com.

>> >> >> To post to this group, send email to

>> >> >> java-serializat...@googlegroups.com.

>> >> >> Visit this group at
>> >> >>
>> >> >> http://groups.google.com/group/java-serialization-benchmarking?hl=en.
>> >> >> For more options, visit https://groups.google.com/groups/opt_out.
>> >> >>
>> >> >>
>> >> >
>> >> > --
>> >> > You received this message because you are subscribed to the Google
>> >> > Groups
>> >> > "java-serialization-benchmarking" group.
>> >> > To unsubscribe from this group and stop receiving emails from it,
>> >> > send
>> >> > an
>> >> > email to

>> >> > java-serialization-be...@googlegroups.com.

>> >> > To post to this group, send email to

>> >> > java-serializat...@googlegroups.com.

>> >> > Visit this group at
>> >> > http://groups.google.com/group/java-serialization-benchmarking?hl=en.
>> >> > For more options, visit https://groups.google.com/groups/opt_out.
>> >> >
>> >> >
>> >
>> > --
>> > You received this message because you are subscribed to the Google
>> > Groups
>> > "java-serialization-benchmarking" group.
>> > To unsubscribe from this group and stop receiving emails from it, send
>> > an

>> > email to java-serialization-be...@googlegroups.com.

>> > To post to this group, send email to

>> > java-serializat...@googlegroups.com.

>> > Visit this group at
>> > http://groups.google.com/group/java-serialization-benchmarking?hl=en.
>> > For more options, visit https://groups.google.com/groups/opt_out.
>> >
>> >
>
> --
> You received this message because you are subscribed to the Google Groups
> "java-serialization-benchmarking" group.
> To unsubscribe from this group and stop receiving emails from it, send an

> email to java-serialization-be...@googlegroups.com.

> To post to this group, send email to

> java-serializat...@googlegroups.com.

[Pressenna]

the run command also depends on make to generate the classpath, which was causing me endless troubles until i figured it out.
hence these launchers, which do nothing but call the ant script to execute java with the correct parameters.

[Tatu Saloranta]

Ah ok.

How do others feel about this? I am not big fan of Make, but at the
same time having 2 build systems can be problematic as well, unless
both are being maintained.

-+ Tatu +-

[Kannan Goundan]

I added the Makefile ~3 years ago because the existing Ant-based build
didn't run the code generation steps and things like that are much
easier to do in Make than in Ant. Ant doesn't even really do
dependencies.

I agree that something in Java would be more convenient (we could even
include the .jar file in the repo). I'd be fine with switching out
the build as long as we don't lose the nice features of the current
Makefile (code generation, only rebuilding the stuff that has
changed).

I wonder if SBT is a good option (we already include the Scala jars in
the repo).

[Tatu Saloranta]

On Wed, Feb 13, 2013 at 2:55 PM, Kannan Goundan <kan...@cakoose.com> wrote:
> I added the Makefile ~3 years ago because the existing Ant-based build
> didn't run the code generation steps and things like that are much
> easier to do in Make than in Ant. Ant doesn't even really do
> dependencies.
>
> I agree that something in Java would be more convenient (we could even
> include the .jar file in the repo). I'd be fine with switching out
> the build as long as we don't lose the nice features of the current
> Makefile (code generation, only rebuilding the stuff that has
> changed).
>
> I wonder if SBT is a good option (we already include the Scala jars in
> the repo).

I am skeptical of using anything related to Scala, due to performance
issues (slow).
Ant is not great, but might work. Maven is usually good for project,
but in this particular case (with experimental versions, somewhat more
complex build) may not be good fit.

-+ Tatu +-

[Sam Pullara]

I'd figure out if you can easily switch to Maven and don't even consider SBT. Otherwise, leave it alone.

Sam

[James Northrup]

3 years almost to the week sicne the topic was active...  it might be easy with the maven pr i submitted.  

On Wednesday, February 13, 2013 at 3:20:18 PM UTC-8, Sam Pullara wrote:

I'd figure out if you can easily switch to Maven and don't even consider SBT. Otherwise, leave it alone.

Sam

On Feb 13, 2013, at 3:18 PM, Tatu Saloranta <tsalo...@gmail.com> wrote:

> On Wed, Feb 13, 2013 at 2:55 PM, Kannan Goundan <kan...@cakoose.com> wrote:
>> I added the Makefile ~3 years ago because the existing Ant-based build
>> didn't run the code generation steps and things like that are much
>> easier to do in Make than in Ant.  Ant doesn't even really do
>> dependencies.
>>
>> I agree that something in Java would be more convenient (we could even
>> include the .jar file in the repo).  I'd be fine with switching out
>> the build as long as we don't lose the nice features of the current
>> Makefile (code generation, only rebuilding the stuff that has
>> changed).
>>
>> I wonder if SBT is a good option (we already include the Scala jars in
>> the repo).
>
> I am skeptical of using anything related to Scala, due to performance
> issues (slow).
> Ant is not great, but might work. Maven is usually good for project,
> but in this particular case (with experimental versions, somewhat more
> complex build) may not be good fit.
>
> -+ Tatu +-
>
> --
> You received this message because you are subscribed to the Google Groups "java-serialization-benchmarking" group.

> To unsubscribe from this group and stop receiving emails from it, send an email to java-serialization-benchmarking+unsubscribe@googlegroups.com.
> To post to this group, send email to java-serialization-benchm...@googlegroups.com.