[cas-dev] Attempt at pull request for cas.personDirectory.principalAttribute

[Sam Hough]

Hi,

I'd like to have a go at providing a fix and automated test for this issue.

https://groups.google.com/a/apereo.org/g/cas-user/c/yMO7izNK1T0/m/MVJR3XXvAgAJ

Anyone know if the original principal should be replaced by the persondir one or if it is a sorting issue?

 Any tips on if it should be a simple junit/unit test or puppet/integration test? Cross module (auth/personDirectory) so should be the latter?

One very minor thing, what is the coding standard for line continuation? Is that the local style? I've only ever used the rules from the original Sun doc https://www.oracle.com/java/technologies/javase/codeconventions-indentation.html

Sorry if I should have been able to find out any of this from the docs.

Cheers

Sam

--
You received this message because you are subscribed to the Google Groups "CAS Developer" group.
To unsubscribe from this group and stop receiving emails from it, send an email to cas-dev+u...@apereo.org.
To view this discussion on the web visit https://groups.google.com/a/apereo.org/d/msgid/cas-dev/f8b141bb-08b5-4c7f-9700-223468046bbbn%40apereo.org.