[jallib/jallib] 9dbf1d: Removed my usb mouse lib and samples. Other mouse ...

[mattschinkel]

Branch: refs/heads/master
Home: https://github.com/jallib/jallib
Commit: 9dbf1d974e6f7c49e2f2a95bcf22067d6280abd3
https://github.com/jallib/jallib/commit/9dbf1d974e6f7c49e2f2a95bcf22067d6280abd3
Author: mattschinkel <mattsc...@hotmail.com>
Date: 2021-12-21 (Tue, 21 Dec 2021)

Changed paths:
R include/peripheral/usb/usb_mouse.jal
R sample/18f26j50_usb_mouse.jal
R sample/18f4550_usb_mouse.jal
R sample/18f67j50_usb_mouse.jal

Log Message:
-----------
Removed my usb mouse lib and samples. Other mouse samples are available.

[vsurducan]

Hi Matt, Rob,

My proposal is to keep various types of the libraries having the same functionality and do not remove them.

Perhaps move it as a complete example in the project folder?

thx,

--
You received this message because you are subscribed to the Google Groups "jallib" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jallib+un...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/jallib/jallib/jallib/push/refs/heads/master/0b1bd9-9dbf1d%40github.com.

[Matt Schinkel]

Hi, thanks for your input. Move which files? The new ones or the old ones? I removed my files for now.

I'm a bit frustrated with looking into updating the existing files. They are generated and I have no way of generating them again. I tried for many hours to get the unit test function of jallib.py to work, and it requires pic shell and there is little documentation.

Not being able to update samples isnt good for us.

Maybe we need to look into making a new jallib supported sample generator. I have my own generator actually but it is for windows. It must be simple enough that anyone can use it. It should be ok to write it in python.

Or we can just not do sample generation. 

Even if I do use my generator, I am careful to look for other people's changes before replacing existing files.

I was thInking of remove all the existing mouse samples, upgrade one or two of them and keep that. I don't see any need to keep old stuff in our sample and lib directories. If someone wants to then take it and put it back into the unit test generator, that is ok with me.

Thanks,

Matt.

Sent from my Android device.

---

From: jal...@googlegroups.com <jal...@googlegroups.com> on behalf of vsurducan <vsur...@gmail.com>
Sent: Wednesday, December 22, 2021 12:06:44 AM
To: jal...@googlegroups.com <jal...@googlegroups.com>
Subject: Re: [jallib] [jallib/jallib] 9dbf1d: Removed my usb mouse lib and samples. Other mouse ...

 

To view this discussion on the web visit https://groups.google.com/d/msgid/jallib/CAM%2Bj4qvcoMVdn7a%2B-dstcN1jcYS-kr6jx%3D%3DSwVmADksojVFkVg%40mail.gmail.com.