[PATCH] mandate pep8 compliance for python code contributions

4 views
Skip to first unread message

Nicholas Mc Guire

unread,
Jul 20, 2016, 6:31:28 AM7/20/16
to jailho...@googlegroups.com, Nicholas Mc Guire
Mandate pep8 coding style checker compliance of python contributions as
basic QA.

Signed-off-by: Nicholas Mc Guire <hof...@osadl.org>
---
CONTRIBUTING.md | 1 +
1 file changed, 1 insertion(+)

diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index 98c7527..17e9d56 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -12,6 +12,7 @@ Contribution Checklist
- use git to manage your changes [*recomended*]

- follow Documentation/coding-style.txt coding style [**required**]
+ - for python code run pep8 coding style checker [**required**]

- add the required copyright header to each new file introduced, see
[licensing information](LICENSING.md) [**required**]
--
1.7.10.4

Henning Schild

unread,
Jul 20, 2016, 6:38:40 AM7/20/16
to Nicholas Mc Guire, jailho...@googlegroups.com
Am Wed, 20 Jul 2016 12:22:08 +0200
schrieb Nicholas Mc Guire <hof...@osadl.org>:

> Mandate pep8 coding style checker compliance of python contributions
> as basic QA.
>
> Signed-off-by: Nicholas Mc Guire <hof...@osadl.org>
> ---
> CONTRIBUTING.md | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
> index 98c7527..17e9d56 100644
> --- a/CONTRIBUTING.md
> +++ b/CONTRIBUTING.md
> @@ -12,6 +12,7 @@ Contribution Checklist
> - use git to manage your changes [*recomended*]
>
> - follow Documentation/coding-style.txt coding style [**required**]
> + - for python code run pep8 coding style checker [**required**]

That is indeed not mentioned anywhere yet. Also that we require python
code to work under both python 3 and 2(.7)
Reply all
Reply to author
Forward
0 new messages