missed branch coverage with instanceof checks

[Tim Webster]

Hi,

I can't work out why Jacoco is reporting missed branch coverage in one of my tests.  There are a bunch of instanceof checks, but for a couple of them it's saying that a branch was missed.  The tests are definitely covering those bits of the code.  A screenshot is attached.

Any ideas?

Thanks.

[Marc R. Hoffmann]

Hi Tim,

is the red block fully exected? If it aborts somewhere in the middle due
to a exception JaCoCo can not mark it as executed.

Cheers,
-marc

> --
> You received this message because you are subscribed to the Google
> Groups "JaCoCo and EclEmma Users" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to jacoco+un...@googlegroups.com.
> For more options, visit https://groups.google.com/groups/opt_out.

[Tim Webster]

that may be it..compareNodes() is recursive, but it throws the exception on the second iteration, so the code does make it through once...would that do it?

Thanks,

Tim

On Wed, Dec 11, 2013 at 7:54 PM, Marc R. Hoffmann <hoff...@mountainminds.com> wrote:

Hi Tim,

is the red block fully exected? If it aborts somewhere in the middle due to a exception JaCoCo can not mark it as executed.

Cheers,
-marc

On 11.12.13 20:19, Tim Webster wrote:

Hi,

I can't work out why Jacoco is reporting missed branch coverage in one of my tests.  There are a bunch of instanceof checks, but for a couple of them it's saying that a branch was missed.  The tests are definitely covering those bits of the code.  A screenshot is attached.

Any ideas?

Thanks.




--
You received this message because you are subscribed to the Google Groups "JaCoCo and EclEmma Users" group.

To unsubscribe from this group and stop receiving emails from it, send an email to jacoco+unsubscribe@googlegroups.com.

For more options, visit https://groups.google.com/groups/opt_out.

--
You received this message because you are subscribed to the Google Groups "JaCoCo and EclEmma Users" group.

To unsubscribe from this group and stop receiving emails from it, send an email to jacoco+unsubscribe@googlegroups.com.

For more options, visit https://groups.google.com/groups/opt_out.

--
Check out my wine blog: http://timswineblog.blogspot.com/

[Marc R. Hoffmann]

Hi Tim,

the block has to return normally at least once (no matter in what recursion). Blocks which are aborted somewhere in the middle with implict exceptions (no explicit throws statement) will not be marked as covered.

Cheers,
-marc

On 11.12.13 21:10, Tim Webster wrote:

that may be it..compareNodes() is recursive, but it throws the exception on the second iteration, so the code does make it through once...would that do it?

Thanks,

Tim

On Wed, Dec 11, 2013 at 7:54 PM, Marc R. Hoffmann <hoff...@mountainminds.com> wrote:

Hi Tim,

is the red block fully exected? If it aborts somewhere in the middle due to a exception JaCoCo can not mark it as executed.

Cheers,
-marc

On 11.12.13 20:19, Tim Webster wrote:

Hi,

I can't work out why Jacoco is reporting missed branch coverage in one of my tests.  There are a bunch of instanceof checks, but for a couple of them it's saying that a branch was missed.  The tests are definitely covering those bits of the code.  A screenshot is attached.

Any ideas?

Thanks.




--
You received this message because you are subscribed to the Google Groups "JaCoCo and EclEmma Users" group.

To unsubscribe from this group and stop receiving emails from it, send an email to jacoco+un...@googlegroups.com.

For more options, visit https://groups.google.com/groups/opt_out.

--
You received this message because you are subscribed to the Google Groups "JaCoCo and EclEmma Users" group.

To unsubscribe from this group and stop receiving emails from it, send an email to jacoco+un...@googlegroups.com.

For more options, visit https://groups.google.com/groups/opt_out.

--
Check out my wine blog: http://timswineblog.blogspot.com/

--
You received this message because you are subscribed to the Google Groups "JaCoCo and EclEmma Users" group.

To unsubscribe from this group and stop receiving emails from it, send an email to jacoco+un...@googlegroups.com.

[Tim Webster]

OK, that sorts out the red block....why do you think the the yellow one is missing branch coverage?  The tests cover both the explicit exception and also with not throwing the exception...

[Marc R. Hoffmann]

What yellow line? Maybe you send a new screenshot with your new coverage.

-marc

On 11.12.13 21:40, Tim Webster wrote:

[Tim Webster]

On line 125 (attached new screenshot), it says 1 of 2 branches missed

--
You received this message because you are subscribed to the Google Groups "JaCoCo and EclEmma Users" group.
To unsubscribe from this group and stop receiving emails from it, send an email to jacoco+un...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.