PRs for transport with new tests and jackalope core changes
7 views
Skip to first unread message
Lukas Kahwe Smith
Feb 9, 2015, 9:53:09 AM2/9/15
to jackal...@googlegroups.com
Aloha,
I wanted to suggest that from now on if we have changes to phpr-api-tests or jackalope/jackalope that a transport PR requires, that we adjust the composer.json in the PR to point to the given dev branches, so that we do not need to merge things in phpcr-api-testes and jackalope/jackalope before we see the transport actually go green with them.
This of course requires that we should best merge locally so that we can revert the composer.json change before we push the merge.
WDYT?
regards,
Lukas Kahwe Smith
sm...@pooteeweet.org
I wanted to suggest that from now on if we have changes to phpr-api-tests or jackalope/jackalope that a transport PR requires, that we adjust the composer.json in the PR to point to the given dev branches, so that we do not need to merge things in phpcr-api-testes and jackalope/jackalope before we see the transport actually go green with them.
This of course requires that we should best merge locally so that we can revert the composer.json change before we push the merge.
WDYT?
regards,
Lukas Kahwe Smith
sm...@pooteeweet.org
Reply all
Reply to author
Forward
0 new messages