becoming a contributor

14 views
Skip to first unread message

Neil Miller

unread,
Sep 5, 2012, 2:20:45 PM9/5/12
to ivyro...@googlegroups.com
So how does one become a contributor? I've been lurking here on this
very quiet mailing list for a while, and submitting patches for new
modules as my need arises. Would be happy to help out with getting new
modules in, etc.

Neil

Archie Cobbs

unread,
Sep 5, 2012, 2:36:04 PM9/5/12
to ivyro...@googlegroups.com
Sounds great. We are liberal in accepting contributors thanks to our low standards :)

I've added you as a contributor. Let me know if you have questions about process, etc.

-Archie

On Wed, Sep 5, 2012 at 1:20 PM, Neil Miller <neil.g.m...@gmail.com> wrote:
So how does one become a contributor? I've been lurking here on this very quiet mailing list for a while, and submitting patches for new modules as my need arises. Would be happy to help out with getting new modules in, etc.


Neil

--
You received this message because you are subscribed to the Google Groups "ivyroundup" group.
To post to this group, send email to ivyro...@googlegroups.com.
To unsubscribe from this group, send email to ivyroundup+unsubscribe@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/ivyroundup?hl=en.




--
Archie L. Cobbs

Neil Miller

unread,
Sep 5, 2012, 3:05:23 PM9/5/12
to ivyro...@googlegroups.com
Will do. I guess I will start be picking up a few of those patches I submitted, and see what questions come up.

-n


On 9/5/12 2:36 PM, Archie Cobbs wrote:
Sounds great. We are liberal in accepting contributors thanks to our low standards :)

I've added you as a contributor. Let me know if you have questions about process, etc.

-Archie

On Wed, Sep 5, 2012 at 1:20 PM, Neil Miller <neil.g.m...@gmail.com> wrote:
So how does one become a contributor? I've been lurking here on this very quiet mailing list for a while, and submitting patches for new modules as my need arises. Would be happy to help out with getting new modules in, etc.


Neil

--
You received this message because you are subscribed to the Google Groups "ivyroundup" group.
To post to this group, send email to ivyro...@googlegroups.com.
To unsubscribe from this group, send email to ivyroundup+...@googlegroups.com.

For more options, visit this group at http://groups.google.com/group/ivyroundup?hl=en.




--
Archie L. Cobbs

--
You received this message because you are subscribed to the Google Groups "ivyroundup" group.
To post to this group, send email to ivyro...@googlegroups.com.
To unsubscribe from this group, send email to ivyroundup+...@googlegroups.com.

Neil Miller

unread,
Sep 5, 2012, 4:18:38 PM9/5/12
to ivyro...@googlegroups.com
Okay, so I've got to the point of running regenrepo.sh and it's modifying almost the entire repo directory. It appears to be just minor formatting changes, but I haven't checked them all (an example is given below). I assume this isn't expected. I could make a changelist with just the files that need to be added, but that doesn't feel like a great solution. Have you seen anything like this before?

-n

$ svn diff repo/modules/org.apache.bcel/bcel/5.1/packager.xml
Index: repo/modules/org.apache.bcel/bcel/5.1/packager.xml
===================================================================
--- repo/modules/org.apache.bcel/bcel/5.1/packager.xml  (revision 2264)
+++ repo/modules/org.apache.bcel/bcel/5.1/packager.xml  (working copy)
@@ -1,5 +1,4 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<!--
+<?xml version="1.0" encoding="UTF-8"?><!--
     Copyright 2009 Mark Thomas
 
     Licensed under the Apache License, Version 2.0 (the "License"); you may

$ svn diff repo/modules/org.apache.bcel/bcel/5.1/ivy.xml
Index: repo/modules/org.apache.bcel/bcel/5.1/ivy.xml
===================================================================
--- repo/modules/org.apache.bcel/bcel/5.1/ivy.xml       (revision 2264)
+++ repo/modules/org.apache.bcel/bcel/5.1/ivy.xml       (working copy)
@@ -1,6 +1,5 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <?xml-stylesheet type="text/xsl" href="../../../../xsl/ivy-doc.xsl"?>
-
 <!--
     Copyright 2009 Mark Thomas



On 9/5/12 2:36 PM, Archie Cobbs wrote:
Sounds great. We are liberal in accepting contributors thanks to our low standards :)

I've added you as a contributor. Let me know if you have questions about process, etc.

-Archie

On Wed, Sep 5, 2012 at 1:20 PM, Neil Miller <neil.g.m...@gmail.com> wrote:
So how does one become a contributor? I've been lurking here on this very quiet mailing list for a while, and submitting patches for new modules as my need arises. Would be happy to help out with getting new modules in, etc.


Neil

--
You received this message because you are subscribed to the Google Groups "ivyroundup" group.
To post to this group, send email to ivyro...@googlegroups.com.
To unsubscribe from this group, send email to ivyroundup+...@googlegroups.com.

For more options, visit this group at http://groups.google.com/group/ivyroundup?hl=en.




--
Archie L. Cobbs

--
You received this message because you are subscribed to the Google Groups "ivyroundup" group.
To post to this group, send email to ivyro...@googlegroups.com.
To unsubscribe from this group, send email to ivyroundup+...@googlegroups.com.

Archie Cobbs

unread,
Sep 5, 2012, 5:01:37 PM9/5/12
to ivyro...@googlegroups.com
Yes, this is a somewhat mysterious problem, I think due to stupid differences in the version of xalan and/or java-built-in XSLT processor between machines.

What is your O/S and Java version?

Are you using the regenrepo.sh script?

I went ahead and regenerated the repo. I also made a change to regenrepo.sh that may help (please try it).

-Archie

Neil Miller

unread,
Sep 5, 2012, 5:33:21 PM9/5/12
to ivyro...@googlegroups.com
Yep, using the script. OS X 10.7.4 and Java version 1.6.0_33.

Tried the updated script, but still shows the same behavior.

I'll try updating Java to the the Oracle Java 7 version.

-n

Neil Miller

unread,
Sep 5, 2012, 6:05:22 PM9/5/12
to ivyro...@googlegroups.com
No luck using 1.7.0_07 either.

Archie Cobbs

unread,
Sep 5, 2012, 6:42:04 PM9/5/12
to ivyro...@googlegroups.com
Hmm.. I normally regenerate on Linux and don't see this problem.

However, when I try it on OS X (same version and java as you) I get the same result as you - a bunch of changes.

To be clear, there's not a real problem with committing all those changes, it's just that it makes it harder to see what you've actually changed and makes the commit operation take much longer (2500 files).

Possible solutions:
  1. Switch me to OS X (not a problem), change all the files over, and hope that's OK with other committers (or, make it their problem :)
  2. Switch to Saxon. This would mean rejiggering apply-xsl.xsl to use XSLT 2.0 instead of pipeDocument.
  3. Debug and solve the problem ... interested? :)
-Archie

Andre-John mas

unread,
Sep 5, 2012, 8:35:37 PM9/5/12
to ivyro...@googlegroups.com, ivyro...@googlegroups.com
Option 3 seems to be the preferable approach, since option 1 didn't really solve the issue for everyone and until we understand the root cause, there is no guarantee option 2 will solve our ills. 

The first things I would look at is the native character encoding and new lines type.  

I have a Mac, so if I have a bit of time I will have a quick look. 

Andre

Sent from my tablet

Neil Miller

unread,
Sep 5, 2012, 8:59:24 PM9/5/12
to ivyro...@googlegroups.com
I was going to suggest option 4: I have access to a linux box. However, I have the exact same issue there. System is a little old:
Ubuntu 10.10
Java 1.6.0_26
Ant 1.8.4
Ivy 2.2.0

Given that, I'd say option 2 or 3, though I can't say the XSLT is my strong suit.

-n

Andre-John Mas

unread,
Sep 5, 2012, 9:58:58 PM9/5/12
to ivyro...@googlegroups.com
Hi,

Just checked on my system and I don't seem to have the issue. 

  OS: MacOS X 10.8.1
  JVM: JVM 1.6.0_29-b11-402
  Ant (retrieved via MacPorts): 1.8.2 compiled on June 20 2012

This was checked with an existing checkout that I upgraded and a freshly checked out one (separate folder).

Just to make sure I am following the same steps as you, I did:

  ./regenrepo.sh
  svn diff repo/modules/


Andre

Mark Thomas

unread,
Sep 5, 2012, 10:32:58 PM9/5/12
to ivyro...@googlegroups.com
can everyone check and see what version of xalan they are using?  archie, isn't there something in the ant build.xml to retrieve and use a specific version of xalan?  2.7.1 i think. i don't know anything about mac ports but on linux using ant rpm ant uses whatever xalan is pointed to in one of the /etc/ant.d/* files.  looks like i am using xalan-j2-2.7.0-253.1.2.noarch

Regards,

Mark Thomas
spatialguru.net@gmail.com
205.529.9013

"Commit to the Lord whatever you do,
    and your plans will succeed." - Proverbs 16:3


Andre-John Mas

unread,
Sep 5, 2012, 10:34:03 PM9/5/12
to ivyro...@googlegroups.com
Looks like I did something wrong before, since I am now getting the same
problem. 

Archie, what version of ant do you have on your Linux system?

I am guessing something changed in the Xerces/Xalan version, but I am
not sure if there is a way to configure the behaviour?

Andre

Archie Cobbs

unread,
Sep 6, 2012, 9:23:54 AM9/6/12
to ivyro...@googlegroups.com
If you look at build.xml it downloads and uses xalan 2.7.1 directly.. at least that's the theory.

I have ant 1.8.2 on both systems. On Linux, java is OpenJDK 1.6.0_22, on Mac it's Java SE 1.6.0_33.

Linux has /etc/ant.d/xalan containing: jaxp_transform_impl xalan-j2-serializer. On Mac OS X /etc/ant.d does not exist.

If everyone else is seeing the "Mac OS X" behavior, then practically speaking why don't we just switch to that?

I still would like to understand what's going on though, just for curiosity's sake.

-Archie

--
You received this message because you are subscribed to the Google Groups "ivyroundup" group.
To post to this group, send email to ivyro...@googlegroups.com.
To unsubscribe from this group, send email to ivyroundup+...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/ivyroundup?hl=en.



--
Archie L. Cobbs

Neil Miller

unread,
Sep 6, 2012, 3:07:35 PM9/6/12
to ivyro...@googlegroups.com
On OS X, I have Ant 1.8.2 (installed so long ago I don't remember where it came from), it does not have Xalan in the lib folder (just ant-apache-xalan2.pom) so the version of Xalan used should be whatever is retrieved via the build script.

Running 'ant -diagnostics' I see, in one section:
-------------------------------------------
 XSLT Processor information
-------------------------------------------
XSLT Processor : com.sun.org.apache.xalan.internal.xsltc.trax.TransformerImpl
XSLT Processor Location: unknown

On Ubuntu, I've tried 1.8.2 and 1.8.4 downloaded directly from Apache. Those came with xalan2.jar but I removed that because it didn't work at all with that in place, so they should also be using whatever is retrieved via the build script. Note though that, running 'ant -diagnostics' has the same XSLT info.

I'm not sure this makes a difference, but it is interesting that the machine that on which it works "normally" is using OpenJDK.

Archie could you try using the Sun, err, Oracle JDK on that machine?

-n

Neil Miller

unread,
Sep 6, 2012, 3:17:00 PM9/6/12
to ivyro...@googlegroups.com
Or option 5: we could move to having a CI system and never committing
the repo as a user. Instead simply make changes to the source files,
test repo generation and then commit the source; after that the CI
system takes care of the rest. If we went this route I'd suggest moving
repo out of trunk and putting it next to wiki in the Subversion repository.

-n

Archie Cobbs

unread,
Sep 6, 2012, 3:34:25 PM9/6/12
to ivyro...@googlegroups.com
I can't easily replace the JDK on this machine (it's a production machine) but this is interesting:

On Mac OS X:

$ ant -diagnostics |grep XSLT
 XSLT Processor information

XSLT Processor : com.sun.org.apache.xalan.internal.xsltc.trax.TransformerImpl
XSLT Processor Location: unknown

On the Linux box:

$ ant -diagnostics | grep XSLT
 XSLT Processor information
XSLT Processor : org.apache.xalan.transformer.TransformerIdentityImpl
XSLT Processor Location: file:/usr/share/java/xalan-j2-2.7.0.jar

The Linux box is openSUSE which uses the JPackage setup for ant with /etc/ant.d. When I remove /etc/ant.d/xalan on the Linux box the behavior switches back:

$ ant -diagnostics | grep XSLT
XSLT Processor information

XSLT Processor : com.sun.org.apache.xalan.internal.xsltc.trax.TransformerImpl
XSLT Processor Location: unknown

and the regeneration of the repo suddenly behaves consistently with OS X.

What I really don't understand is this: the files that are different are generated via Xalan's pipeDocument feature (see src/xsl/apply-xsl.xsl)... which you'd think would always be using Xalan for the nested transforms! So why on earth does the default Transformer implementation matter?

In any case, since the JPackage setup on the Linux box is unusual, I suggest we switch to the "non-Linux" form going forward. Does anybody have an objection to doing that?

-Archie

--
You received this message because you are subscribed to the Google Groups "ivyroundup" group.
To post to this group, send email to ivyro...@googlegroups.com.
To unsubscribe from this group, send email to ivyroundup+...@googlegroups.com.
For more options, visit this group at http://groups.google.com/group/ivyroundup?hl=en.



--
Archie L. Cobbs

Joshua Tharp

unread,
Sep 6, 2012, 4:00:51 PM9/6/12
to ivyro...@googlegroups.com
I used to have my local CI system build the repository for my office's use. I regularly hit places where the packager.xml files were broken because links moved or libraries were no longer reachable, which subsequently failed the build. It happened frequently enough that I stopped monitoring the changes in ivyroundup and started installing individual jar files only as I needed them. If you add a CI system to ivyroundup, it would be nice if the CI build detected these types of situations and flagged those modules as broken.

--
You received this message because you are subscribed to the Google Groups "ivyroundup" group.
To post to this group, send email to ivyro...@googlegroups.com.
To unsubscribe from this group, send email to ivyroundup+unsubscribe@googlegroups.com.

Andre-John Mas

unread,
Sep 6, 2012, 8:30:15 PM9/6/12
to ivyro...@googlegroups.com, ivyro...@googlegroups.com
Is there any way to create a checksum of the XML data, as opposed to its unparsed text form?

André-John

Sent from my phone. Envoyé depuis mon téléphone. 
To unsubscribe from this group, send email to ivyroundup+...@googlegroups.com.

Archie Cobbs

unread,
Sep 7, 2012, 9:06:05 AM9/7/12
to ivyro...@googlegroups.com
On Thu, Sep 6, 2012 at 2:34 PM, Archie Cobbs <arc...@dellroad.org> wrote:
In any case, since the JPackage setup on the Linux box is unusual, I suggest we switch to the "non-Linux" form going forward. Does anybody have an objection to doing that?

No objections raised so I'm proceeding to "switch"...

-Archie

--
Archie L. Cobbs

Reply all
Reply to author
Forward
0 new messages