Issue 346 in iui: Checking for back-links (in navigation stack) broken since REL-0.40-dev3 (when iui.busy was added)

[i...@googlecode.com]

Status: Started
Owner: msgilli...@gmail.com
CC: remi.gru...@gmail.com
Labels: Type-Defect Milestone-REL-0.40 Priority-Critical

New issue 346 by msgilli...@gmail.com: Checking for back-links (in
navigation stack) broken since REL-0.40-dev3 (when iui.busy was added)
http://code.google.com/p/iui/issues/detail?id=346

1. Click on a link and let a new page slide in.
2. In the new page click on a link to #home

Expected result: iUI returns to #home with a backwards scroll

Incorrect result: iUI pushes #home on the nav stack and does a forward
scroll to home

[i...@googlecode.com]

Comment #1 on issue 346 by msgilli...@gmail.com: Checking for back-links

(in navigation stack) broken since REL-0.40-dev3 (when iui.busy was added)
http://code.google.com/p/iui/issues/detail?id=346

I added a test-case for easy reproduction here:
https://github.com/iui/iUI/commit/a1d0fd6217317ce01ec1f77fc7df0c6ca6333280

[i...@googlecode.com]

Comment #2 on issue 346 by msgilli...@gmail.com: Checking for back-links

(in navigation stack) broken since REL-0.40-dev3 (when iui.busy was added)
http://code.google.com/p/iui/issues/detail?id=346

This change cleans up iui.busy handling for ajax links (but does not fix
the bug)
https://github.com/iui/iUI/commit/b3de1ca14c95434d748c2395a5530b8997adb35a

[i...@googlecode.com]

Comment #3 on issue 346 by msgilli...@gmail.com: Checking for back-links

(in navigation stack) broken since REL-0.40-dev3 (when iui.busy was added)
http://code.google.com/p/iui/issues/detail?id=346

This is the commit that actually fixes the bug:
https://github.com/iui/iUI/commit/c348613cd2e8db45aeb3a37daf1937eff257b563

[i...@googlecode.com]

Comment #4 on issue 346 by msgilli...@gmail.com: Checking for back-links

(in navigation stack) broken since REL-0.40-dev3 (when iui.busy was added)
http://code.google.com/p/iui/issues/detail?id=346

Remi, why don't you check out the changes on comment on them on GitHub.

(Yes, I think it's time to make GitHub our primary code repository...)

[i...@googlecode.com]

Comment #5 on issue 346 by msgilli...@gmail.com: Checking for back-links

(in navigation stack) broken since REL-0.40-dev3 (when iui.busy was added)
http://code.google.com/p/iui/issues/detail?id=346

I want to take a closer look at the code that decides whether "view" is a
node or a node ID string. That may not be done properly for cross-browser.