Issue 974 in iterm2: XCode 4/Lion build fixes.Mouse wheel scrolling in alt screen mode.

3 views
Skip to first unread message

ite...@googlecode.com

unread,
Jun 1, 2011, 11:01:29 AM6/1/11
to iterm2...@googlegroups.com
Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 974 by vczi...@gmail.com: XCode 4/Lion build fixes.Mouse wheel
scrolling in alt screen mode.
http://code.google.com/p/iterm2/issues/detail?id=974

Here's a patch against trunk that fixes build problems on Lion/XCode4.
(There's no MacOSX10.5.sdk and no ppc support on those platforms).

The project builds against MacOSX10.6.sdk and removes PPC builds.

It also fixes an issue with Growl.framework library name by making it
relative to the executable path
(@executable_path../Frameworks/Growl.framework).

The patch also adds mouse wheel scrolling support when a terminal is in
MOUSE_REPORTING_NONE mouse mode and is using an alternate screen by
translating them to arrow up/down terminfo escape sequences. (ala MouseTerm
).

This allows for instance a user to use its mouse wheel to scroll through a
man page (like in konsole or gnome-terminal on linux).


Attachments:
iTerm2_full.patch 8.3 KB

ite...@googlecode.com

unread,
Jun 1, 2011, 12:30:32 PM6/1/11
to iterm2...@googlegroups.com

Comment #1 on issue 974 by gnach...@gmail.com: XCode 4/Lion build
fixes.Mouse wheel scrolling in alt screen mode.
http://code.google.com/p/iterm2/issues/detail?id=974

Thanks! I will apply this for 1.1, as features are closed for 1.0.

ite...@googlecode.com

unread,
Jul 23, 2011, 11:12:56 PM7/23/11
to iterm2...@googlegroups.com

Comment #2 on issue 974 by gnach...@gmail.com: XCode 4/Lion build
fixes.Mouse wheel scrolling in alt screen mode.
http://code.google.com/p/iterm2/issues/detail?id=974

On second look, I don't think I can apply this as it stands. The scroll
wheel can still be used to navigate the scrollback history in alternate
screen mode, and this breaks that functionality. There could be a
per-profile preference to enable that behavior.

ite...@googlecode.com

unread,
Jul 29, 2011, 2:11:50 PM7/29/11
to iterm2...@googlegroups.com

Comment #3 on issue 974 by vczi...@gmail.com: XCode 4/Lion build
fixes.Mouse wheel scrolling in alt screen mode.
http://code.google.com/p/iterm2/issues/detail?id=974

I agree with you and I will resubmit a patch with per-profile preference as
soon as I find 5 minutes.

I think the logical choice to put a preference for that is in the 'Terminal'
tab under the 'Enable xterm mouse reporting' check box.
The new check box could be titled 'Scroll Wheel emulates KeyUp/KeyDown in
alternate screen mode' .
I couldn't come up with a better self-describing title that succeed in
conveying what the option does to a user.

Any suggestions ?

ite...@googlecode.com

unread,
Jul 29, 2011, 4:04:26 PM7/29/11
to iterm2...@googlegroups.com

Comment #4 on issue 974 by geor...@google.com: XCode 4/Lion build
fixes.Mouse wheel scrolling in alt screen mode.
http://code.google.com/p/iterm2/issues/detail?id=974

How about "Scroll wheel sends up and down arrow keys in alternate screen",
if it fits?
Also, please remove the 10.6 sdk stuff as we will continue supporting 10.5
through the next release.

ite...@googlecode.com

unread,
Mar 12, 2014, 2:59:41 PM3/12/14
to iterm2...@googlegroups.com

Comment #5 on issue 974 by riarh...@gmail.com: XCode 4/Lion build
fixes.Mouse wheel scrolling in alt screen mode.
http://code.google.com/p/iterm2/issues/detail?id=974

This issue is quite old, the original diff does not apply. For those who
need the patch and cannot wait for a good solution to appear, here's
another diff against the modern git source.

Attachments:
iterm2-alternate-mousescroll.diff 2.7 KB

--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

ite...@googlecode.com

unread,
Mar 12, 2014, 8:31:15 PM3/12/14
to iterm2...@googlegroups.com

Comment #6 on issue 974 by filosottile.wiki: XCode 4/Lion build fixes.Mouse
wheel scrolling in alt screen mode.
http://code.google.com/p/iterm2/issues/detail?id=974

Thanks! Proposed as a PR wrapped in a hidden setting here
https://github.com/gnachman/iTerm2/pull/164

ite...@googlecode.com

unread,
Mar 12, 2014, 11:08:41 PM3/12/14
to iterm2...@googlegroups.com
Updates:
Status: Duplicate
Mergedinto: 2311

Comment #7 on issue 974 by gnach...@gmail.com: XCode 4/Lion build
fixes.Mouse wheel scrolling in alt screen mode.
http://code.google.com/p/iterm2/issues/detail?id=974

(No comment was entered for this change.)
Reply all
Reply to author
Forward
0 new messages