Issue 2925 in iterm2: Transparent artifacts in bottom corners

[ite...@googlecode.com]

Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 2925 by pi...@krawiec.me: Transparent artifacts in bottom corners
http://code.google.com/p/iterm2/issues/detail?id=2925

What steps will reproduce the problem?
1. Put a dark-background iTerm window on top of any white-background window.

What is the expected output?
The round corners at the bottom of the iTerm window blend nicely into the
other window in the background.

What do you see instead?
The attached screenshot visualizes it much better than I could describe.
One thing worth mention is that the "artifacts" the arrows are pointing to
are transparent.

What version of iTerm2 are you using?
I was able to reproduce this problem with both 1.0.0.20140112 beta (OS
10.6+, Intel-only) and iTerm2-1_0_0_20140311-nightly.

What OS version are you using?
10.9.2

Attachments:
screenshot.png 41.7 KB
com.googlecode.iterm2.plist 10.1 KB

--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[ite...@googlecode.com]

Comment #1 on issue 2925 by gnach...@gmail.com: Transparent artifacts in
bottom corners
http://code.google.com/p/iterm2/issues/detail?id=2925

This is caused by using the private api _setContentHasShadow. Its benefit
is that it prevents transparent windows from having a "ghosting" effect as
seen in issue 299, and this is its cost. Google Chrome does the same thing
(change here:
https://codereview.chromium.org/11316172/diff/1002/ui/base/cocoa/underlay_opengl_hosting_window.mm)
and exhibits the same issue on my system.

I could try testing if there is a transparent view and only enabling it in
that case.

[ite...@googlecode.com]

Comment #2 on issue 2925 by pi...@krawiec.me: Transparent artifacts in
bottom corners
http://code.google.com/p/iterm2/issues/detail?id=2925

I can't reproduce the issue with Chrome, do I need to have some transparent
theme installed? Or maybe they're doing the workaround you mentioned?

[ite...@googlecode.com]

Comment #3 on issue 2925 by gnach...@gmail.com: Transparent artifacts in
bottom corners
http://code.google.com/p/iterm2/issues/detail?id=2925

Here's what I see with chrome and iterm compared. The white pixels in the
corner are the same, and disappear in iterm when I turn off this flag.
Based on the image you sent, I'm guessing you have a non-retina display,
which might explain the difference.

Attachments:
chrome_vs_iterm.png 33.6 KB

[ite...@googlecode.com]

Comment #4 on issue 2925 by pi...@krawiec.me: Transparent artifacts in
bottom corners
http://code.google.com/p/iterm2/issues/detail?id=2925

Right, tried dark background in Chrome and indeed, it's the same issue.
Thanks for pointing me in the right direction. I think it's still slightly
more irritating in iTerm, since (educated guess here) vast majority of use
cases involve dark backgrounds - whereas in Chrome, it's probably the other
way around.

Anyway, it's your judgment if fixing this rather minor annoyance is worth
introducing a workaround to a workaround to a bigger problem (i.e. issue
299). As far as I understand, it won't even be a full workaround, since
it'll only help with non-transparent backgrounds. On the other hand, if
somebody opts for some degree of transparency, two fully transparent pixels
in the corners probably won't annoy them as much.