Issue 31 in israfil-mojo: Binary options bug
codesite...@google.com
http://code.google.com/p/israfil-mojo/issues/detail?id=31
New issue report by mohammedsaleem:
This issue hasn't been fixed in the new version.
http://groups.google.com/group/israfil-mojo-users/browse_thread/thread/b39520bc07b0d87/165886a9d2a8d683?hl=en&lnk=gst&q=binary+options#165886a9d2a8d683
Issue attributes:
Status: New
Owner: ----
Labels: Type-Defect Priority-Medium
--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings
codesite...@google.com
http://code.google.com/p/israfil-mojo/issues/detail?id=31
Comment #1 by christianedwardgruber:
The referenced comment was:
i noticed a bug in your compiler-wrapper design. You are using
> // add in binary options.
> if (optimize) javaParms.add("-compiler.optimize");
> if (profile) javaParms.add("-compiler.profile");
> if (strict) javaParms.add("-compiler.strict");
> if (useNetwork) javaParms.add("-use-network");
> if (warnings) javaParms.add("-warnings");
> if (incremental) javaParms.add("-compiler.incremental");
> if (showActionscriptWarnings)
> javaParms.add("-show-actionscript-warnings");
> if (showBindingWarnings) javaParms.add("-show-binding-warnings");
> if (showDeprecationWarnings)
> javaParms.add("-show-deprecation-warnings");
for adding in the binary options. The problem is that some of the mxmlc
options have a default value of "true" [1]. Because of that, setting
these properties (e.g. useNetwork) to "false" in the pom will not work
as expected.
A patch would be to add the options with
> javaParms.add("-use-network=" + useNetwork);
as you did for the "debug" option as well.
Please keep on working on this very useful project :-)
kind regards,
Holger
[1] http://livedocs.adobe.com/flex/2/docs/00001500.html#157203
codesite...@google.com
http://code.google.com/p/israfil-mojo/issues/detail?id=31
Comment #2 by christianedwardgruber:
I'm not sure all the binaries should be handled this way - I agree that
this is a problem, though, so I'm going to
audit the flags and see which ones differ and move their settings into
the relevant child mojo.
Essentially the default will still need to be right, so making this
change simply means that it's wrong, but fixable
in configuration. It should be correct by default.
Issue attribute updates:
Status: Accepted
Labels: Affects-Release-1.3 Milestone-Release-1.4 Severity-High
codesite...@google.com
http://code.google.com/p/israfil-mojo/issues/detail?id=31
Comment #3 by mohammedsaleem:
thts true, not all binaries can be treated that way. but i didn't get
your point
when you said "Essentially the default will still need to be right, so
making this
change simply means that it's wrong, but fixable
in configuration.".
If we have the above patch, and then give the default value for those
flags as the
default value in mxmlc, it should be fine right?