Islandora 7 and Windows: Patches to Review

[slanger]

I’ve discovered a number of Windows-incompatibilities in the 7.x-1.2 release of Islandora. I’ve created a series of patches to fix them. Once a module is patched, it should work in both Linux and Windows environments.

It would be great if the Islandora Development Team could review these patches and consider incorporating them into one of the next releases of Islandora.

You can review the patches here:

• Islandora 7 and Windows: Patches and Tips
  

Thanks!

[Jordan Dukart]

It's awesome that you've put in the work to facilitate Windows as an OS for Islandora. May I suggest sending pull requests to the modules/library you've modified as opposed to just posting .patches? If you do do this, it will to be noted that HEAD has obviously progressed since the 7.x-1.2 release and merge conflicts will likely occur. Finally, do the SimpleTests that exact for the core modules still pass with these updated changes?

Jordan
On 2013-12-29 4:32 PM, slanger wrote:

I�ve discovered a number of Windows-incompatibilities in the 7.x-1.2 release of Islandora. I�ve created a series of patches to fix them. Once a module is patched, it should work in both Linux and Windows environments.

It would be great if the Islandora Development Team could review these patches and consider incorporating them into one of the next releases of Islandora.

You can review the patches here:

• Islandora 7 and Windows: Patches and Tips
  

Thanks!

--
You received this message because you are subscribed to the Google Groups "islandora-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an email to islandora-de...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[Nick Ruest]

+1 for Windows support.

We have some pretty good info up on the Islandora site for
developers[1], that should be able to help guide you. There are even
some great guidelines and best practices for Git[2] up on the Islandora
Github wiki.

If those don't help, let us know how we can make them better, and if you
just need a hand, feel free to ask here, or hope over into #islandora on
freenode where a few up hang out. Although, there may not be too many
folks there right now because of the holidays ;-)

thanks again, and cheers!

-nruest

[1] http://islandora.ca/developers
[2]
https://github.com/Islandora/islandora/wiki/Git-Guidelines-and-Best-Practices

On 13-12-30 12:54 PM, Jordan Dukart wrote:
> It's awesome that you've put in the work to facilitate Windows as an OS
> for Islandora. May I suggest sending pull requests to the
> modules/library you've modified as opposed to just posting .patches? If
> you do do this, it will to be noted that HEAD has obviously progressed
> since the 7.x-1.2 release and merge conflicts will likely occur.
> Finally, do the SimpleTests that exact for the core modules still pass
> with these updated changes?
>
> Jordan
> On 2013-12-29 4:32 PM, slanger wrote:
>> I�ve discovered a number of Windows-incompatibilities in the 7.x-1.2
>> release of Islandora. I�ve created a series of patches to fix them.
>> Once a module is patched, it should work in both Linux and Windows
>> environments.
>>
>> It would be great if the Islandora Development Team could review these
>> patches and consider incorporating them into one of the next releases
>> of Islandora.
>>
>> You can review the patches here:
>>

>> * Islandora 7 and Windows: Patches and Tips
>> <https://groups.google.com/d/msg/islandora/0MAhLDjbago/9knbOynlyIcJ>

[Jonathan Green]

Thanks so much for the contributions! As Jordan said, it would be super helpful for reviewing patches if you could submit pull requests to the Islandora repositories. We use the github "fork and pull" model. As well as the documentation that Nick posted here is some really good github documentation on the fork and pull model:
https://help.github.com/articles/using-pull-requests

On Mon, Dec 30, 2013 at 5:07 PM, Nick Ruest <rue...@gmail.com> wrote:

+1 for Windows support.

We have some pretty good info up on the Islandora site for developers[1], that should be able to help guide you. There are even some great guidelines and best practices for Git[2] up on the Islandora Github wiki.

If those don't help, let us know how we can make them better, and if you just need a hand, feel free to ask here, or hope over into #islandora on freenode where a few up hang out. Although, there may not be too many folks there right now because of the holidays ;-)

thanks again, and cheers!

-nruest

[1] http://islandora.ca/developers
[2] https://github.com/Islandora/islandora/wiki/Git-Guidelines-and-Best-Practices

On 13-12-30 12:54 PM, Jordan Dukart wrote:

It's awesome that you've put in the work to facilitate Windows as an OS
for Islandora. May I suggest sending pull requests to the
modules/library you've modified as opposed to just posting .patches? If
you do do this, it will to be noted that HEAD has obviously progressed
since the 7.x-1.2 release and merge conflicts will likely occur.
Finally, do the SimpleTests that exact for the core modules still pass
with these updated changes?

Jordan
On 2013-12-29 4:32 PM, slanger wrote:

I’ve discovered a number of Windows-incompatibilities in the 7.x-1.2
release of Islandora. I’ve created a series of patches to fix them.

Once a module is patched, it should work in both Linux and Windows
environments.

It would be great if the Islandora Development Team could review these
patches and consider incorporating them into one of the next releases
of Islandora.

You can review the patches here:

  * Islandora 7 and Windows: Patches and Tips
    <https://groups.google.com/d/msg/islandora/0MAhLDjbago/9knbOynlyIcJ>

Thanks!

--
You received this message because you are subscribed to the Google
Groups "islandora-dev" group.
To unsubscribe from this group and stop receiving emails from it, send

an email to islandora-dev+unsubscribe@googlegroups.com.

For more options, visit https://groups.google.com/groups/opt_out.

--
You received this message because you are subscribed to the Google
Groups "islandora-dev" group.
To unsubscribe from this group and stop receiving emails from it, send

an email to islandora-dev+unsubscribe@googlegroups.com.

For more options, visit https://groups.google.com/groups/opt_out.

--
You received this message because you are subscribed to the Google Groups "islandora-dev" group.

To unsubscribe from this group and stop receiving emails from it, send an email to islandora-dev+unsubscribe@googlegroups.com.

For more options, visit https://groups.google.com/groups/opt_out.

--

Jonathan Green
Chief Technology Officer
discoverygarden Inc.
Sims Office Suites Building, 3rd Floor, 118 Sydney Street
Charlottetown, PE C1A 1G4
902.367.3851 discoverygarden.ca
skype: jonathan.edwards.green

[slanger]

Thanks, Jordan, nick and Jonathan for the links and advice.

I cloned the most recent version of each Islandora module (post-7.x-1.2) and adapted my patches to fit them; so hopefully, that will reduce the number of merge conflicts later on.

I now have ten pull requests on GitHub:

• Islandora Repository module
• Audio Solution Pack
• Compound Solution Pack
• Large Image Solution Pack
• FITS Extractor module
• Islandora OCR module
• Islandora Paged Content module
• Internet Archive Book Viewer module
• OpenSeadragon module
• Tuque library

NOTE 1: The latest version of the PDF Solution Pack has rendered my patch unnecessary.

NOTE 2: It's my first time working with GitHub outside of drupal.org; so let me know if I've missed something and/or made some egregious error along the way.

Otherwise, let the games begin! :-)

an email to islandora-de...@googlegroups.com.

For more options, visit https://groups.google.com/groups/opt_out.

--
You received this message because you are subscribed to the Google
Groups "islandora-dev" group.
To unsubscribe from this group and stop receiving emails from it, send

an email to islandora-de...@googlegroups.com.

For more options, visit https://groups.google.com/groups/opt_out.

--
You received this message because you are subscribed to the Google Groups "islandora-dev" group.

To unsubscribe from this group and stop receiving emails from it, send an email to islandora-de...@googlegroups.com.

For more options, visit https://groups.google.com/groups/opt_out.

[Peter Murray]

While we don’t use Windows in our environment, I wanted to send out a “kudos to you” for helping to broaden the possible community of Islandora users. Thanks for your effort!


Peter

Peter Murray
Assistant Director, Technology Services Development
LYRASIS
Peter....@lyrasis.org
+1 678-235-2955
800.999.8558 x2955

[Nick Ruest]

slangerx++

-nruest

On 14-01-09 03:15 PM, Peter Murray wrote:
> While we don�t use Windows in our environment, I wanted to send out a �kudos to you� for helping to broaden the possible community of Islandora users. Thanks for your effort!

>> I�ve discovered a number of Windows-incompatibilities in the 7.x-1.2
>> release of Islandora. I�ve created a series of patches to fix them.