Since 2.25 cannot build on macOS 10.13

[Liviu Ionescu]

Hi,

I tried to upgrade my GCC builds to the latest 2.26 and I noticed that the build failed, apparently in a test. The console output is at the end.

The latest GCC 14 with all its latest dependencies built from sources compiles fine on macOS 10.13, except isl which must be downgraded to 2.24.

It would be great to keep compatibility with older macOS.

Thank you,

Liviu

---------------------------

/usr/bin/clang++ -std=c++11 -std=gnu++17 -DHAVE_CONFIG_H   -I. -I/Users/ilg/Work/xpack-dev-tools/gcc-xpack.git/build/darwin-x64/sources/isl-0.26 -I/Users/ilg/Work/xpack-dev-tools/gcc-xpack.git/build/darwin-x64/sources/isl-0.26/include -Iinclude/  -I/Users/ilg/Work/xpack-dev-tools/gcc-xpack.git/build/darwin-x64/x86_64-apple-darwin18.7.0/install/include   -ffunction-sections -fdata-sections -pipe -O2 -mmacosx-version-min=10.13 -w -c -o isl_test_cpp17-checked.o /Users/ilg/Work/xpack-dev-tools/gcc-xpack.git/build/darwin-x64/sources/isl-0.26/isl_test_cpp17-checked.cc
/usr/bin/clang -DHAVE_CONFIG_H   -I. -I/Users/ilg/Work/xpack-dev-tools/gcc-xpack.git/build/darwin-x64/sources/isl-0.26 -I/Users/ilg/Work/xpack-dev-tools/gcc-xpack.git/build/darwin-x64/sources/isl-0.26/include -Iinclude/  -I/Users/ilg/Work/xpack-dev-tools/gcc-xpack.git/build/darwin-x64/x86_64-apple-darwin18.7.0/install/include  -Wall  -ffunction-sections -fdata-sections -pipe -O2 -mmacosx-version-min=10.13 -w -c -o dep.o /Users/ilg/Work/xpack-dev-tools/gcc-xpack.git/build/darwin-x64/sources/isl-0.26/dep.c
rm -f libdep.a
/usr/bin/ar cru libdep.a dep.o
/Library/Developer/CommandLineTools/usr/bin/ranlib: file: libdep.a(dep.o) has no symbols
/usr/bin/ranlib libdep.a
/Library/Developer/CommandLineTools/usr/bin/ranlib: file: libdep.a(dep.o) has no symbols
warning: /Library/Developer/CommandLineTools/usr/bin/ranlib: warning for library: libdep.a the table of contents is empty (no object file members in the library define global symbols)
In file included from /Users/ilg/Work/xpack-dev-tools/gcc-xpack.git/build/darwin-x64/sources/isl-0.26/isl_test_cpp17-checked.cc:23:
/Users/ilg/Work/xpack-dev-tools/gcc-xpack.git/build/darwin-x64/sources/isl-0.26/isl_test_cpp17-generic.cc:48:16: error: call to unavailable member function 'value': introduced in macOS 10.14
        if (maybe_int.value() != 5)
            ~~~~~~~~~~^~~~~
/Library/Developer/CommandLineTools/usr/include/c++/v1/optional:946:27: note: candidate function has been explicitly made unavailable
    constexpr value_type& value() &
                          ^
/Library/Developer/CommandLineTools/usr/include/c++/v1/optional:937:33: note: candidate function has been explicitly made unavailable
    constexpr value_type const& value() const&
                                ^
/Library/Developer/CommandLineTools/usr/include/c++/v1/optional:955:28: note: candidate function not viable: no known conversion from 'optional<...>' to 'optional<...>' for object argument
    constexpr value_type&& value() &&
                           ^
/Library/Developer/CommandLineTools/usr/include/c++/v1/optional:964:34: note: candidate function not viable: no known conversion from 'optional<...>' to 'const optional<...>' for object argument
    constexpr value_type const&& value() const&&
                                 ^
In file included from /Users/ilg/Work/xpack-dev-tools/gcc-xpack.git/build/darwin-x64/sources/isl-0.26/isl_test_cpp17-checked.cc:23:
/Users/ilg/Work/xpack-dev-tools/gcc-xpack.git/build/darwin-x64/sources/isl-0.26/isl_test_cpp17-generic.cc:63:15: error: call to unavailable member function 'value': introduced in macOS 10.14
                if (maybe_s.value()->freed != &freed)
                    ~~~~~~~~^~~~~
/Library/Developer/CommandLineTools/usr/include/c++/v1/optional:946:27: note: candidate function has been explicitly made unavailable
    constexpr value_type& value() &
                          ^
/Library/Developer/CommandLineTools/usr/include/c++/v1/optional:937:33: note: candidate function has been explicitly made unavailable
    constexpr value_type const& value() const&
                                ^
/Library/Developer/CommandLineTools/usr/include/c++/v1/optional:955:28: note: candidate function not viable: no known conversion from 'optional<...>' to 'optional<...>' for object argument
    constexpr value_type&& value() &&
                           ^
/Library/Developer/CommandLineTools/usr/include/c++/v1/optional:964:34: note: candidate function not viable: no known conversion from 'optional<...>' to 'const optional<...>' for object argument
    constexpr value_type const&& value() const&&
                                 ^

---------------------------

[Sven Verdoolaege]

On Thu, Apr 18, 2024 at 01:14:11AM -0700, Liviu Ionescu wrote:
> error: call to unavailable member function 'value': introduced in macOS
> 10.14
> if (maybe_int.value() != 5)
> ~~~~~~~~~~^~~~~
> /Library/Developer/CommandLineTools/usr/include/c++/v1/optional:946:27:
> note: candidate function has been explicitly made unavailable
> constexpr value_type& value() &
> ^

Thanks for the report.
AFAIU, this is a problem in older versions of macOS.
The attached work-around should solve the problem.
Does it?

skimo

[Liviu Ionescu]

> On 18 Apr 2024, at 23:35, Sven Verdoolaege <sven.ver...@telenet.be> wrote:
>
> The attached work-around should solve the problem.
> Does it?

Yes, thank you, I added the patch and the build passed.

Do you plan to integrate it into the next release?


Liviu

[Sven Verdoolaege]

Yes.

Thanks,

skimo