[PATCH] isl_ctx_free: clarify error message

2 views
Skip to first unread message

skim...@kotnet.org

unread,
Aug 31, 2021, 3:33:19 PM8/31/21
to isl-dev...@googlegroups.com, Victor Minden
From: Sven Verdoolaege <sv...@cerebras.net>

When isl_ctx_free gets called when it is still being referenced
by some objects, an error gets printed and the isl_ctx object
is not freed. However, the original error message sounds
as if the isl_ctx object is getting freed.
Clarify that this is not the case.

Requested-by: Victor Minden <victor...@cerebras.net>
Signed-off-by: Sven Verdoolaege <sv...@cerebras.net>
---
isl_ctx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/isl_ctx.c b/isl_ctx.c
index 176fd6f56a..017e4af888 100644
--- a/isl_ctx.c
+++ b/isl_ctx.c
@@ -291,7 +291,7 @@ void isl_ctx_free(struct isl_ctx *ctx)
return;
if (ctx->ref != 0)
isl_die(ctx, isl_error_invalid,
- "isl_ctx freed, but some objects still reference it",
+ "isl_ctx not freed as some objects still reference it",
return);

if (ctx->opt->print_stats)
--
2.25.1

Reply all
Reply to author
Forward
0 new messages