[PATCH] rootfs-u-boot: add missing import get_bitbake_var

[Liu Yi]

The variable image_rootfs_dir will not be correctly defined if missing import of get_bitbake_var func.

Signed-off-by: Liu Yi <li...@siemens.com>
---
meta/scripts/lib/wic/plugins/source/rootfs-u-boot.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta/scripts/lib/wic/plugins/source/rootfs-u-boot.py b/meta/scripts/lib/wic/plugins/source/rootfs-u-boot.py
index 7dde49d4..5611f93a 100644
--- a/meta/scripts/lib/wic/plugins/source/rootfs-u-boot.py
+++ b/meta/scripts/lib/wic/plugins/source/rootfs-u-boot.py
@@ -20,7 +20,7 @@ import os

from wic import WicError
from wic.plugins.source.rootfs import RootfsPlugin
-from wic.misc import exec_cmd
+from wic.misc import get_bitbake_var, exec_cmd

logger = logging.getLogger('wic')

--
2.39.2

[Jan Kiszka]

Interesting. The code was like that since its beginning 6 years ago. How
did you trigger the issue? Maybe you can augment the commit message with
this information. Otherwise:

Reviewed-by: Jan Kiszka <jan.k...@siemens.com>

Thanks,
Jan

--
Siemens AG, Technology
Linux Expert Center

[Yi Liu]

This issue was found by my VSCode, which hinted that some error there when I went through this python file.

Best Regards,

Liu Yi 

[Jan Kiszka]

On 19.06.24 08:55, 'Yi Liu' via isar-users wrote:
> This issue was found by my VSCode, which hinted that some error there
> when I went through this python file.
>

OK, than this might be magically resolved otherwise in the context of
wic, and that is why it remained unnoticed so far.

Jan

> --
> You received this message because you are subscribed to the Google
> Groups "isar-users" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to isar-users+...@googlegroups.com
> <mailto:isar-users+...@googlegroups.com>.
> To view this discussion on the web visit
> https://groups.google.com/d/msgid/isar-users/ab71bc45-1955-46eb-af2c-50182f2af0ecn%40googlegroups.com <https://groups.google.com/d/msgid/isar-users/ab71bc45-1955-46eb-af2c-50182f2af0ecn%40googlegroups.com?utm_medium=email&utm_source=footer>.

[Uladzimir Bely]

Applied to next, thanks.

--
Best regards,
Uladzimir.