Capacity

[Stefano Maestri]

Hi all,

I've started to work on 

https://github.com/ironjacamar/ironjacamar/issues/461

Designing this ported feature I've extended Extension to support module name and slot to have a general solution of issues like

https://issues.jboss.org/browse/WFLY-2492

You can see the commit here:

https://github.com/ironjacamar/ironjacamar/commit/a8d5ba28a4c0ed1421ea3e73279f0b662220614e

The problem in WFly will remain how to load classes from those module, so I'm adding a ClassLoaderPlugin SPI into IJ to native support those cases

https://github.com/ironjacamar/ironjacamar/commit/a3c6e2741a4c67a27fb48082c699e7dfae7af268

any comments or concerns are more than welcome

I'll update the forum w/ other commits to support capacity feature in few days. Any suggestion request on this is welcome too

regards

S.

[Jesper Pedersen]

Great !

Other than the new classloader integration, I think that the functionality mainly should stay the same as the 1.2 branch.

Only package changes moving

• pool.api.Capacity -> pool.Capacity
• pool.api.CapacityIncrementer -> pool.CapacityIncrementer
• pool.api.CapacityDecrementer -> pool.CapacityDecrementer

The pool.capacity package can stay the way it is IMHO. The actual configuration should likely be stored at pool level, e.g. show up in core.api.deploymentrepository.Pool.

[Jesper Pedersen]

CapacityIncrementer and CapacityDecrementer of course has to be moved to core.api.connectionmanager.pool for them to be able to show up in api.deploymentrepository...

[Lin Gao]

Happy to know that JBoss module-name and module-slot will be supported in IronJacamar side.

I think current design can cover the issues like: https://issues.jboss.org/browse/WFLY-2492 very well. :-)

One trivial issue is at [1], this line does not use the ClassLoaderPlugin to load the extension class yet. :-)

[1] https://github.com/ironjacamar/ironjacamar/blob/e8a424909e9e6ea14bdc6e61eaf138aa888c2c61/deployers/src/main/java/org/ironjacamar/deployers/common/AbstractResourceAdapterDeployer.java#L951


Best Regards

[Stefano Maestri]

I've committed implementations and tests for capacity concepts using new classloading functionality

https://github.com/ironjacamar/ironjacamar/commit/ab1d3b98b9ef4a1dcf062354b4c94aa8b850a83c

any comments and feedback are more than welcome

regards

S.

[Jesper Pedersen]

Good to see it in :)

I think the policies ported over from 1.2 will still cover the most frequent use-cases with SizeIncrementer and TimedoutDecrementer taking the lead.