RFC: Create a new iree-org/base-docker-images repository

30 views
Skip to first unread message

Scott Todd

unread,
Aug 22, 2024, 1:23:59 PM8/22/24
to iree-discuss
I propose we fork https://github.com/nod-ai/base-docker-images/ into iree-org. This new repository will then be used to replace the https://github.com/iree-org/iree/tree/main/build_tools/docker directory as we port or retire the Dockerfiles that remain:
  • base-arm64
  • base-bleeding-edge
  • base
  • emscripten
  • riscv-toolchain-builder
  • riscv
That list used to be much longer - it had 20 Dockerfiles this time last year. Of the images that remain, I'm expecting that we'll be able to replace them with something more like https://github.com/nod-ai/base-docker-images/blob/main/dockerfiles/manylinux_ghr_x86_64.Dockerfile (the pkgci_build_packages workflow is already using that specific Dockerfile).

With the base dockerfile repository in iree-org, we'll be able to resolve https://github.com/iree-org/iree/issues/15332. Updating the dockerfiles will require only write access permissions, which contributors already have:
  1. Send a pull request modifying the dockerfiles in that repo
  2. Code is reviewed and merged
  3. A GitHub Actions workflow builds the dockerfiles and pushes to the Docker registry in GitHub Packages (https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-docker-registry)
  4. Repositories like iree-org/iree then either pick up the latest `:main` version or a pinned version of the package

Thoughts / objections? Any suggestions on the repository name, or keep using "base-docker-images"?

Jacques Pienaar

unread,
Aug 22, 2024, 1:26:41 PM8/22/24
to Scott Todd, iree-discuss
SGTM

--
You received this message because you are subscribed to the Google Groups "iree-discuss" group.
To unsubscribe from this group and stop receiving emails from it, send an email to iree-discuss...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/iree-discuss/9a4b1ce1-fdd8-4342-9710-8df8d4d70195n%40googlegroups.com.

Stella Laurenzo

unread,
Aug 22, 2024, 1:33:47 PM8/22/24
to Jacques Pienaar, Scott Todd, iree-discuss
SGTM

I don't think repo docker repos redirect or else I'd say we can just transfer it. Can do that if you think it would work. Or just use it as a starting point is fine.


Scott Todd

unread,
Aug 22, 2024, 1:39:34 PM8/22/24
to iree-discuss
I was planning on either using as a starting point or mechanically forking (keeping the commit history, likely without the GitHub association of a "fork"). I also figured we could keep the original repository in its current location, as a place for nod-ai / AMD-specific dockerfiles. Not sure if we'll need it, but easy enough to keep it up just in case -- and existing references to `ghcr.io/nod-ai/` will continue working without needing to worry about redirects as you point out.

Scott Todd

unread,
Aug 22, 2024, 6:23:56 PM8/22/24
to iree-discuss
Repo created and configured: https://github.com/iree-org/base-docker-images . I kept the existing dockerfiles from the original repo without making any changes / simplifications.

The first few packages are published, so I'll try swapping workflows in iree-org/iree to use them. Afterwards, we can add new dockerfiles for what is left in iree-org/iree.

Reply all
Reply to author
Forward
0 new messages