Classification inside RegistryPackage in ITI-18 response

[Cyrill Zadra]

Hi

Classification element in SubmissionSet (RegistryPackage element) can be inside of RegistryPackage but also outside -> https://profiles.ihe.net/ITI/TF/Volume3/ch-4.2.html#4.2.1.2.1 . 

IPF encodes it outside in a ITI-18 Response.

<RegistryObjectList>
<RegistryPackage >
<...>
</RegistryPackage>
<Classification
classifiedObject="SubmissionSetId"
classificationNode="urn:uuid:a54d6aa5-d40d-43f9-88c5-b4633d873bdd"
id="urn:uuid:1d4d08bc-85cc-4596-8fdc-4b5410a6feae"
objectType="urn:oasis:names:tc:ebxml-regrep:ObjectType:RegistryObject:Classification"/>
</RegistryObjectList>

Is there an easy way to change this behaviour such that Classification element is encoded inside RegistryObject element?

thanks & regards

Cyrill

[Dmytro Rud]

Hi Cyrill

Your feature request is registered as https://github.com/oehf/ipf/issues/435.

Best regards

Dmytro

--
You received this message because you are subscribed to the Google Groups "ipf-user" group.
To unsubscribe from this group and stop receiving emails from it, send an email to ipf-user+u...@googlegroups.com.
To view this discussion on the web visit https://groups.google.com/d/msgid/ipf-user/e8e144d2-b907-4180-a09d-7aac0812e0b9n%40googlegroups.com.

[Thomas Papke]

Hallo  Cyrill,

just for my understanding, can you please outline which improvement / benefit this change will bring for you?

Best regards,

Thomas

[Dmytro Rud]

Hello Cyrill

Please take a look at the today's commit.  Placement of classifications is implemented uniformly for Submission Sets and Folders.  Per default, the behavior remains as it was, i.e. classifications are created outside of these objects.  To change this, you can set the JVM variables org.openehealth.ipf.commons.ihe.xds.core.transform.ebxml.LeafClassTransformer#PROPERTY_SUBMISSION_SET_CLASSIFICATION_INSIDE and/or org.openehealth.ipf.commons.ihe.xds.core.transform.ebxml.LeafClassTransformer#PROPERTY_FOLDER_CLASSIFICATION_INSIDE to "true" (case-insensitive).

Please test and let me know whether the ticket can be closed.

Best regards

Dmytro

To view this discussion on the web visit https://groups.google.com/d/msgid/ipf-user/f2c605bb-77eb-43c3-9f34-9b485952de37n%40googlegroups.com.

[Cyrill Zadra]

Hi Thomas

We have a setup where we are xds registry with one xds consumer. ITI-18 consumer cannot handle Classification elements outside the RegistryObject element. Now I am analyzing if it is easily customizable by IPF and since I have not found anything concrete in the code itself, I have now asked the question here in the mailling list. Maybe I have overlooked something. :-).

Just curious .. would it be wrong if registry sends Classification inside and outside at the same time? 

regards

[Cyrill Zadra]

Hi Dmytro

Wow thanks... i'll give it a try and let you know if works.

regards

[Dmytro Rud]

> Just curious .. would it be wrong if registry sends Classification inside and outside at the same time?

Your question can be interpreted in two different ways:

1. Is it allowed to have two classifications for the same Submission Set -- one inside, one outside?

2. Is it allowed to have in the same message (e.g. in an ITI-18 response) a Submission Set with an inside classification and a Submission Set with an outside classification?  (E.g. if different Document Sources use different approaches, and the Document Registry does not re-structure their submissions.)

From my point of view, the both questions can be answered with "yes", as there are no inconsistencies in the XDS metadata.

Independeptly from all that, there may be a schizophrenic situation where the same RegistryPackage is classified both as a Submission Set and as a Folder.  And this will even pass the validation it the said RegistryPackage contains all attributes necessary for the both object types.

Best regards

Dmytro

To view this discussion on the web visit https://groups.google.com/d/msgid/ipf-user/57831545-b2d5-4664-8ad8-d0494df0ccban%40googlegroups.com.

[Cyrill Zadra]

Hi Dmytro

Did some testing and it works .. great and thanks. Will there be a 4.8-m4 release in the near future?

regards

Cyrill

[Cyrill Zadra]

Hi all

Are there any plans to bake a new milestone release in the next few days?

thx & regards

cyrill