Hello everyone,
with the last changes to 5.0-m2 the ipf-commons-xua was probably dropped by accident, currently there is only a swiss xua handling in SwissEpr.
I would vote to also bring back a “simple” Ihe xua handling.
I was already in a first exchange with Dmytro about some ideas:
A) Dmytro bring the following first proposal.
1 eliminate WsAuditDatasetEnricher.NOOP.
2. introduce a non-Swiss-specific implementation instead of NOOP as default.
3. leave a Swiss-specific implementation as plug-in.
4. redefine the field AbstractAuditInterceptor.wsAuditDatasetEnricher as final, because it is hardly conceivable that you want to dynamically readjust something in a short-lived interceptor.
Advantage: Xua is included by default without an extra module
Disadvantage: Noop would no longer exist
Proposal 2:
1 Reactivate the ihe-commons-xua module
2 Stay with the WsAuditDatasetEnricher Interface in commons-ws
3 Provide a commons-ihe-xua implementation of WsAuditDatasetEnricher and one in a swiss specific module
Advantage: adaption similar to the way in ipf 4.x
Disadvantage: at least 2 modules with 1 class each
Proposal 3:
Include the BasicXuaProcessor in ihe-commons-ws, but WITHOUT the serviceloader definition. This means that if someone wants to switch from Noop to basic-Xua, the ServiceLoader definition must be created in the application under Meta-Inf.
Advantage: One Maven module saved
Disadvantage: Existing applications must be adapted
What are your opinion on this topic?
My preference would be option 2 :-)
Best regards,
Thomas