Issue 70 in ioostech: IOOS-SOS.GetObservation-ResponseMatchingProcedureData.1 asserts procedure equality

3 views
Skip to first unread message

ioos...@googlecode.com

unread,
Jul 11, 2014, 4:34:49 PM7/11/14
to iooste...@googlegroups.com
Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 70 by srstcl...@gmail.com:
IOOS-SOS.GetObservation-ResponseMatchingProcedureData.1 asserts procedure
equality
http://code.google.com/p/ioostech/issues/detail?id=70

I notice that IOOS test
[https://code.google.com/p/ioostech/wiki/ListofTestsIOOSSOS#3.3.2_IOOS-specific_Tests
getObservation:IOOS-SOS.GetObservation-ResponseMatchingProcedureData.1]
make the following assertion:

GetObservation requests made for each 'procedure' element advertised in
the Capabilities document produce the responses with <om:procedure> values
that...match the 'procedure' values specified in the requests.

This won't be true if a GetObservation request is made for a network, since
the om:procedure Process members will be the constituent stations.

--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

ioos...@googlecode.com

unread,
Jul 11, 2014, 6:08:53 PM7/11/14
to iooste...@googlegroups.com

Comment #1 on issue 70 by sh...@axiomalaska.com:
IOOS-SOS.GetObservation-ResponseMatchingProcedureData.1 asserts procedure
equality
http://code.google.com/p/ioostech/issues/detail?id=70

This is problem when a sensor procedure is requested too, because
om:procedure will still list stations. In other words, om:procedure always
lists matching stations, not necessarily the requested procedure.

ioos...@googlecode.com

unread,
Jul 23, 2014, 5:09:43 PM7/23/14
to iooste...@googlegroups.com

Comment #2 on issue 70 by abir...@gmail.com:
IOOS-SOS.GetObservation-ResponseMatchingProcedureData.1 asserts procedure
equality
http://code.google.com/p/ioostech/issues/detail?id=70

OK, it looks like we can fix it in 2 ways:

Option 1 is to rephrase clause (a) to match the OGC CITE test assertion:

"GetObservation requests made for each 'procedure' element advertised in
the Capabilities document produce the responses with <om:procedure> values
that (a) match the 'procedure' values OR ARE A SUBSET OF THE PROCEDURE
VALUES specified in the requests, and (b) are in a form of URN that
conforms to the IOOS Conventions for Observing Asset Identifiers."

Outcome: fixes the "network" issue, since station procedures are members
(i.e. subset) of the network process; however, the "sensor" issue stays
broken.


Option 2 is to rephrase the assertion to focus the assertion upon a single
station/platform:

"GetObservation requests made for each SINGLE PLATFORM/STATION 'procedure'
element advertised in the Capabilities document produce the responses with
<om:procedure> values that (a) match the 'procedure' values specified in
the requests, and (c) are in a form of URN that conforms to the IOOS
Conventions for Observing Asset Identifiers."

Outcome: fixes both "network" and "sensor" issues by moving them out of the
scope of the assertion.

Option 2 seems more correct just because I believe that the test in
question was really supposed to complement
the "getObservation:IOOS-SOS.GetObservation-ResponseMatchingProcedureData.2"
test, which targets a networks of stations, and the assertion was just
poorly worded.

ioos...@googlecode.com

unread,
Jul 23, 2014, 5:11:53 PM7/23/14
to iooste...@googlegroups.com

Comment #3 on issue 70 by sh...@axiomalaska.com:
IOOS-SOS.GetObservation-ResponseMatchingProcedureData.1 asserts procedure
equality
http://code.google.com/p/ioostech/issues/detail?id=70

Great, +1 for option 2.

ioos...@googlecode.com

unread,
Jul 23, 2014, 5:51:51 PM7/23/14
to iooste...@googlegroups.com

Comment #4 on issue 70 by abir...@gmail.com:
IOOS-SOS.GetObservation-ResponseMatchingProcedureData.1 asserts procedure
equality
http://code.google.com/p/ioostech/issues/detail?id=70

OK, I will update the assertion. I am moving the documentation in
abirger/Docs repository on GitHub, so I will make this update, and change
the names of the tests (issue #71) at the same time.

ioos...@googlecode.com

unread,
Jul 28, 2014, 4:37:38 PM7/28/14
to iooste...@googlegroups.com

Comment #5 on issue 70 by abir...@gmail.com:
IOOS-SOS.GetObservation-ResponseMatchingProcedureData.1 asserts procedure
equality
http://code.google.com/p/ioostech/issues/detail?id=70

Committed the updated version of the List to abirger/Docs repository on
GitHub. The test in question got updated as provided by Option 2.

ioos...@googlecode.com

unread,
Aug 16, 2014, 1:05:00 AM8/16/14
to iooste...@googlegroups.com
Updates:
Status: Fixed

Comment #6 on issue 70 by sh...@axiomalaska.com:
IOOS-SOS.GetObservation-ResponseMatchingProcedureData.1 asserts procedure
equality
http://code.google.com/p/ioostech/issues/detail?id=70

Looks good, closing. Thanks!
Reply all
Reply to author
Forward
0 new messages