Issue 87 in innotop: Use of uninitialized value $mysqlversion in pattern match (m//) at /usr/local/bin/innotop line 473.

[inn...@googlecode.com]

Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 87 by tinu...@gmail.com: Use of uninitialized value $mysqlversion
in pattern match (m//) at /usr/local/bin/innotop line 473.
http://code.google.com/p/innotop/issues/detail?id=87

[root@ innotop-1.9.1]$ /usr/local/bin/innotop --version
innotop Ver 1.9.1
[root@ innotop-1.9.1]$ mysql -V
mysql Ver 14.14 Distrib 5.5.27, for Linux (x86_64) using EditLine wrapper

Use of uninitialized value $mysqlversion in pattern match (m//) at
/usr/local/bin/innotop line 473.

--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[inn...@googlecode.com]

Comment #1 on issue 87 by mike.vit...@visaops.com: Use of uninitialized

value $mysqlversion in pattern match (m//) at /usr/local/bin/innotop line
473.
http://code.google.com/p/innotop/issues/detail?id=87

I have the same problem, any solution?

[inn...@googlecode.com]

Comment #2 on issue 87 by mike.vit...@visaops.com: Use of uninitialized

value $mysqlversion in pattern match (m//) at /usr/local/bin/innotop line
473.
http://code.google.com/p/innotop/issues/detail?id=87

i got around my problem by replacing the contents of the innotop.conf file
from another machine where it did not have this problem. The only thing I
did differently was choose to encrypt my password on the second machine
where it didn't work.

[inn...@googlecode.com]

Comment #3 on issue 87 by mike.vit...@visaops.com: Use of uninitialized

[inn...@googlecode.com]

Comment #4 on issue 87 by przemek....@gmail.com: Use of uninitialized value

$mysqlversion in pattern match (m//) at /usr/local/bin/innotop line 473.
http://code.google.com/p/innotop/issues/detail?id=87

This is how to reproduce the problem. Tested on version 1.9.1 on Centos 6.4.
This error happens for me when I use one of mentioned below modes, and have
more then one connection defined, for example:

[connections]

local=user=root have_user=1 pass=myPASS have_pass=1
dsn=DBI:mysql:;host=localhost savepass=1 dl_table=
local2=user=root have_user=1 pass=myPASS have_pass=1
dsn=DBI:mysql:;host=localhost savepass=1 dl_table=

[/connections]

So when I enter one of these modes: D, I, L, R or T. It not always does
crash with this error while entering these modes, but if I leave one of
these as default in configuration, Innotop crashes always on start even if
only single connection is defined. For example:

# Which mode to start in
mode=R

What is interesting, when another mode is default, e.g. Q - I can run and
then switch to any of these without any problems.
But when I add second connection, and switch between connections in one of
these modes, Innotop crashes with the same error.

In order to avoid this error, first disable auto config saving:

# Whether the config file is read-only
readonly=1

Make one of the stable modes as default, like:

# Which mode to start in
mode=M

and try to not enter D, I, L, R or T modes when you have more then one
connection defined.

[inn...@googlecode.com]

Updates:
Status: Accepted

Comment #5 on issue 87 by lefred.d...@gmail.com: Use of uninitialized value

$mysqlversion in pattern match (m//) at /usr/local/bin/innotop line 473.
http://code.google.com/p/innotop/issues/detail?id=87

I confirm that when you start with mode = B, D, F, R or T in
~/.innotop/innotop.conf line 36. It crash with that error.

With mode L it crashes even when just entering in that mode after having
started with mode A for example.

[inn...@googlecode.com]

Comment #6 on issue 87 by phil.hil...@gmail.com: Use of uninitialized value

$mysqlversion in pattern match (m//) at /usr/local/bin/innotop line 473.
http://code.google.com/p/innotop/issues/detail?id=87

I ran into this same issue.

It appeared the check was only to see if the version matched 5.6, so I
just added defined $mysqlversion && to the version check and it fixed the
issue for me.

this is the patch :


--- innotop 2013-10-17 21:29:46.751320827 +0000
+++ innotop.fix 2013-10-17 22:00:15.608185659 +0000
@@ -470,7 +470,7 @@
# too many locks to print, the output might be truncated)

my $time_text;
- if ( $mysqlversion =~ /^5\.6/ ) {
+ if ( defined $mysqlversion && $mysqlversion =~ /^5\.6/ ) {
( $time_text ) = $fulltext =~ m/^([0-9-]* [0-9:]*) [0-9a-f]* INNODB
MONITOR OUTPUT/m;
$innodb_data{'ts'} = [ parse_innodb_timestamp_56( $time_text ) ];
} else {

[inn...@googlecode.com]

Comment #7 on issue 87 by g...@dakin.be: Use of uninitialized value

$mysqlversion in pattern match (m//) at /usr/local/bin/innotop line 473.
http://code.google.com/p/innotop/issues/detail?id=87

Issue 91 has been merged into this issue.

[inn...@googlecode.com]

Updates:
Status: Fixed

Comment #8 on issue 87 by g...@dakin.be: Use of uninitialized value

$mysqlversion in pattern match (m//) at /usr/local/bin/innotop line 473.
http://code.google.com/p/innotop/issues/detail?id=87

Fixed in revision 121