Issue 83 in innotop: Some pages broken with MySQL 5.6

[inn...@googlecode.com]

Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 83 by ira...@gmail.com: Some pages broken with MySQL 5.6
http://code.google.com/p/innotop/issues/detail?id=83

What steps will reproduce the problem?
1. Run innotop
2. Go to Row Ops page
3.

What is the expected output? What do you see instead?
The program crashes with the following message: "Use of uninitialized value
$text in pattern match (m//) at /usr/local/bin/innotop line 613."

What version of the product are you using? On what operating system?
innotop version 1.9.0 on CentOS 6.3 x86_64. Perl version 5.10.1
x86_64-linux-thread-multi

Please provide any additional information below.

--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[inn...@googlecode.com]

Comment #1 on issue 83 by brett.w...@gmail.com: Some pages broken with
MySQL 5.6
http://code.google.com/p/innotop/issues/detail?id=83

Same issues with Mac OS X

innotop version 1.9.0 on Darwin Kernel Version 12.3.0. Perl v5.12.4, mySQL
v5.6.11. This seems to have broken with the mySQL update.

[inn...@googlecode.com]

Comment #2 on issue 83 by kenny.g...@percona.com: Some pages broken with
MySQL 5.6
http://code.google.com/p/innotop/issues/detail?id=83

I confirm this as well.

Attached you can find a patch that has better 5.6 support.

Attachments:
innotop-support-56.txt 3.7 KB

[inn...@googlecode.com]

Comment #3 on issue 83 by kenny.g...@percona.com: Some pages broken with
MySQL 5.6
http://code.google.com/p/innotop/issues/detail?id=83

Some background information:

The following lines have changed the timestamp format and line:

5.5: 130610 11:56:18 INNODB MONITOR OUTPUT
5.6: 2013-06-07 14:03:59 7fa9be1b7700 INNODB MONITOR OUTPUT

&
(Foreign Key Errors)
5.5: 130610 11:56:31 Transaction:
5.6: 2013-06-07 12:39:23 7fa9be239700 Transaction:

[inn...@googlecode.com]

Comment #4 on issue 83 by dnelson_...@yahoo.com: Some pages broken with
MySQL 5.6
http://code.google.com/p/innotop/issues/detail?id=83

This patch doesn't seem to work. $mysqlversion isn't set anywhere, and is
redundant anyway since the version_ge() function already exists for
comparing against the mysql version.

[inn...@googlecode.com]

Comment #5 on issue 83 by kenny.g...@percona.com: Some pages broken with
MySQL 5.6
http://code.google.com/p/innotop/issues/detail?id=83

The test suite does not work and will complain about $mysqlversion not
being set, but innotop itself works.

[inn...@googlecode.com]

Comment #6 on issue 83 by kenny.g...@percona.com: Some pages broken with
MySQL 5.6
http://code.google.com/p/innotop/issues/detail?id=83

About version_ge():

I wasn't able to easily use version_ge() (not a perl/programming expert)
because you need the databasehandle, which is not available in those
functions.

[inn...@googlecode.com]

Comment #7 on issue 83 by ira...@gmail.com: Some pages broken with MySQL 5.6
http://code.google.com/p/innotop/issues/detail?id=83

I can confirm that the patch works for innotop itself. Thank you!

[inn...@googlecode.com]

Comment #8 on issue 83 by kenny.g...@percona.com: Some pages broken with
MySQL 5.6
http://code.google.com/p/innotop/issues/detail?id=83

Ppl,

I spent some time adding the perl tests:

- fixed one silly bug where the time was incremented by 2000 years (so 4013)
- added a test SHOW ENGINE INNODB STATUS from 5.6
- Updated the tests to support $mysqlversion and define which SHOW ENGINE
INNODB STATUS file is which mysql version.


Attached you can find the complete patch.

Attachments:
innotop-mysql5.6-with-working-tests.txt 17.7 KB

[inn...@googlecode.com]

Updates:
Status: Fixed

Comment #9 on issue 83 by g...@dakin.be: Some pages broken with MySQL 5.6
http://code.google.com/p/innotop/issues/detail?id=83

fixed in commit 111

[inn...@googlecode.com]

Comment #10 on issue 83 by jon...@gmail.com: Some pages broken with MySQL
5.6
https://code.google.com/p/innotop/issues/detail?id=83

I'm happy this bug is fixed, but will you be releasing a new version any
time soon?

[inn...@googlecode.com]

Comment #11 on issue 83 by lefred.d...@gmail.com: Some pages broken with
MySQL 5.6
https://code.google.com/p/innotop/issues/detail?id=83

Innotop is now hosted on github (https://github.com/innotop/innotop) please
use it from there. There are no plan to make packages release currently.