Issue 89 in innotop: Use of uninitialized value in subroutine entry at /usr/local/bin/innotop line 6308

[inn...@googlecode.com]

Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

New issue 89 by przemek....@gmail.com: Use of uninitialized value in
subroutine entry at /usr/local/bin/innotop line 6308
http://code.google.com/p/innotop/issues/detail?id=89

* What steps will reproduce the problem?
1. Configure a server group from at least 2 servers
2. Enter 'C' (Command Summary) mode and choose the server group
3. Innotop quits with error:
"Use of uninitialized value in subroutine entry at /usr/local/bin/innotop
line 6308, <FIN> line 1."

* What is the expected output? What do you see instead?
Not sure what the output should look like, since for many servers it won't
fit, but at least it should not crash Innotop. Maybe disable server groups
for C mode?

* What version of the product are you using? On what operating system?
Innotop 1.9.1
Centos 6.4 (Perl v5.10.1) or Fedora 18 (Perl v5.16.3)


--
You received this message because this project is configured to send all
issue notifications to this address.
You may adjust your notification preferences at:
https://code.google.com/hosting/settings

[inn...@googlecode.com]

Updates:
Status: Accepted

Comment #1 on issue 89 by lefred.d...@gmail.com: Use of uninitialized value

in subroutine entry at /usr/local/bin/innotop line 6308
http://code.google.com/p/innotop/issues/detail?id=89

I can reproduce the problem, now I need to dig in the code to see how I can
resolve it.

[inn...@googlecode.com]

Comment #2 on issue 89 by waseemno...@gmail.com: Use of uninitialized value

in subroutine entry at /usr/local/bin/innotop line 6308
http://code.google.com/p/innotop/issues/detail?id=89

When this error will be fixed? I checked the line and it has following code

my $max_width = max( length($info->{$_}->{hdr}), map {
length($_->{$col_name}) } @$data);

[inn...@googlecode.com]

Comment #3 on issue 89 by lefred.d...@gmail.com: Use of uninitialized value

in subroutine entry at /usr/local/bin/innotop line 6308

https://code.google.com/p/innotop/issues/detail?id=89

from debugging, this is what we have inside the variable:

DB<18> print Dumper($info);
$VAR1 = {
cxn => {trans => []},
last_pct => {
agg => 'first',
agghide => 0,
aggonly => 0,
dec => 0,
func => sub { "DUMMY" },
hdr => 'Pct',
just => '',
label => 'Last Percentage',
maxw => 0,
minw => 0,
num => 1,
src => 'last_value/last_total',
tbl => '',
trans => ['percent'],
user => 0
},
last_value => {
agg => 'sum',
agghide => 0,
aggonly => 0,
dec => 0,
func => sub { "DUMMY" },
hdr => 'Last Incr',
just => '',
label => 'Last Value',
maxw => 0,
minw => 0,
num => 1,
src => 'last_value',
tbl => '',
trans => [],
user => 0
},
name => {
agg => 'first',
agghide => 0,
aggonly => 0,
dec => 0,
func => sub { "DUMMY" },
hdr => 'Name',
just => '-',
label => 'Variable Name',
maxw => 0,
minw => 0,
num => 0,
src => 'name',
tbl => '',
trans => $VAR1->{last_value}{trans},
user => 0
},
pct => {
agg => 'first',
agghide => 0,
aggonly => 0,
dec => 0,
func => sub { "DUMMY" },
hdr => 'Pct',
just => '',
label => 'Percentage',
maxw => 0,
minw => 0,
num => 1,
src => 'value/total',
tbl => '',
trans => ['percent'],
user => 0
},
value => {
agg => 'sum',
agghide => 0,
aggonly => 0,
dec => 0,
func => sub { "DUMMY" },
hdr => 'Value',
just => '',
label => 'Value',
maxw => 0,
minw => 0,
num => 1,
src => 'value',
tbl => '',
trans => $VAR1->{last_value}{trans},
user => 0
}
};

We need to verify what is and if we can bypass it : cxn => {trans => []},

[inn...@googlecode.com]

Comment #4 on issue 89 by lefred.d...@gmail.com: Use of uninitialized value

in subroutine entry at /usr/local/bin/innotop line 6308
https://code.google.com/p/innotop/issues/detail?id=89

The problem comes from the connection that's empty (undef) :

$VAR1 = {cxn => undef,last_pct => '25.00%',last_total => 12,last_value
=> '6',name => 'Com_admin_commands',pct => '62.65%',total => 14186,value =>
8951};
DB<8> c
main::create_table(innotop:6304): map { $row->{$_} =
collapse_ws($row->{$_}) } @$cols;
DB<8> print Dumper($row);
$VAR1 = {cxn => undef,last_pct => '8.33%',last_total => 12,last_value
=> '2',name => 'Com_show_status',pct => '31.97%',total => 14186,value =>
4572};
DB<9> c
main::create_table(innotop:6304): map { $row->{$_} =
collapse_ws($row->{$_}) } @$cols;
DB<9> print Dumper($row);
$VAR1 = {cxn => undef,last_pct => '0.00%',last_total => 12,last_value
=> '0',name => 'Com_show_processlist',pct => '1.29%',total => 14186,value
=> 197};

[inn...@googlecode.com]

Comment #5 on issue 89 by frederic...@percona.com: Use of uninitialized

value in subroutine entry at /usr/local/bin/innotop line 6308
https://code.google.com/p/innotop/issues/detail?id=89

Fix has been pushed into trunk

[inn...@googlecode.com]

Updates:
Status: New
Owner: lefred.d...@gmail.com

Comment #6 on issue 89 by lefred.d...@gmail.com: Use of uninitialized value

in subroutine entry at /usr/local/bin/innotop line 6308
https://code.google.com/p/innotop/issues/detail?id=89

I mark it as fixed, but please test the resolving