[Regression] Line wrap on Task Dialog is broken since 6.4.3

[Bruno Lopes]

Before 6.4.3:

With 6.4.3 (unproportionally long dialog):

[Alex Born]

One flag has been added for the task dialog (commit).

Yeah, now the task dialog looks unfortunate.

But you can get used to it. :)

понедельник, 5 мая 2025 г. в 15:24:25 UTC+2, Bruno Lopes:

[Bruno Lopes]

>  But you can get used to it. :)

Hard to get used to awfully designed dialogs :). Even that long task dialog appearing only one time, it creates a pretty bad impression on the first user which now needs to move its eyes horizontally a lot.

I mean, the new behavior is more consistent with MsgBox, cool; but that change was made without message adjustment on the .isl files so we got that questionable result.

[Jordan Russell]

On 5/5/25 10:06 AM, Alex Born wrote:
> One flag has been added for the task dialog

The TDF_SIZE_TO_CONTENT flag was added because I found that
not-unreasonably-long paths shown in error messages were being truncated
with ellipses ("..."). For example, this is too long to fit with the
standard dialog width:

C:\Users\username\AppData\Local\Programs\My Program\MyProg.exe

I don't recall exactly where it was being truncated, but it looked
something like this:

C:\Users\username\AppData\Local\P...\MyProg.exe

TDF_SIZE_TO_CONTENT increases the dialog's maximum width by about 50%
(it doesn't disable wrapping), which prevents truncation in the above
case. But truncation can still happen with longer paths.

Perhaps to avoid the needless widening of the "Select install mode"
dialog, it could only set the TDF_SIZE_TO_CONTENT flag when the message
appears to contain a full path, e.g. if it contains ":\" or "\\".

I would prefer that the dialog wrap overlong paths instead of truncating
them (like MessageBox does), but there doesn't appear to be any flag for it.

-JR

[Martijn Laan]

Op di 6 mei , Jordan Russell <jr-f...@jrsoftware.org> schreef:

Perhaps to avoid the needless widening of the "Select install mode"
dialog, it could only set the TDF_SIZE_TO_CONTENT flag when the message
appears to contain a full path, e.g. if it contains ":\" or "\\".

Or it could check the message to see if there's actually a long word in it? That way it wouldn't trigger on short paths either.

Greetings,

Martijn