Would I migrate this in 6.5.5?

79 views
Skip to first unread message

Andrew Truckle

unread,
Aug 12, 2025, 2:01:27 PMAug 12
to innosetup
Thank you for the new version and your hard work.

At the moment I include the following as part of my installer:

[Run]
; Install the downloaded help documentation.
; This is only done if the "downloadhelp" task was selected.
Filename: "{tmp}\HelpDocSetup.exe"; \
    Parameters: "/SP- /VERYSILENT /InstallPath=""{app}"""; \
    WorkingDir: "{app}"; \
    Flags: waituntilterminated runhidden; \
    Description: "{cm:InstallingHelpDescription}"; \
    StatusMsg: "{cm:InstallingHelpStatusMessage}"; \
    Tasks: downloadhelp

[Tasks]
Name: "downloadhelp"; Description: "{cm:DownloadHelpTask}"; GroupDescription: "{cm:DownloadHelpGroup}"; Flags: unchecked

Is this a good candidate for the new download mechanism in the [Files] section? Or should it stay as-is?

Thank you,
Andrew

Martijn Laan

unread,
Aug 12, 2025, 2:18:39 PMAug 12
to innosetup
Hey,

Op 12-8-2025 om 20:01 schreef Andrew Truckle:
Thank you for the new version and your hard work.

Thanks!


Is this a good candidate for the new download mechanism in the [Files] section? Or should it stay as-is?

If your HelpDocSetup.exe is actually just an archive then yeah, you could download and verify and extract a .7z or .zip instead. Any files coming from the archive will be uninstalled normally. You can also update the archive and still verify it without having to updating the installer which does the download. Using a Task parameter to make it conditional is also fine. It's all pretty awesome if you ask me 😋

It would enable you to remove both the [Run] entry and the [Code] you didn't show but must have. And it will give you 'evergreen' verification if you use issigverify.

There's a new DownloadFiles.iss example script demonstrating all of this, except that it doesn't use tasks.

Greetings,
Martijn

Andrew Truckle

unread,
Aug 12, 2025, 3:19:11 PMAug 12
to innosetup
You are right, I do have a [Code] bit too:

function NextButtonClick(CurPageID: integer): boolean;
begin
    Result := True;
 
  if (CurPageID = wpSelectTasks) then
  begin
    DownloadPage.Clear;

    if (WizardIsTaskSelected('downloadhelp')) then
      AddFileForDownload('{#HelpDocSetupURL}', 'HelpDocSetup.exe',
            '{#GetSHA256OfFile("..\HelpNDoc\CHM\Output\MSAHelpDocumentationSetup.exe")}');
  end
    else
  if (CurPageID = wpReady) then
  begin
    DownloadPage.Show;
    try
      try
        DownloadPage.Download;
        Result := True;
      except
        SuppressibleMsgBox(
          AddPeriod(GetExceptionMessage), mbCriticalError, MB_OK, IDOK);
        Result := False;
      end;
    finally
      DownloadPage.Hide;
    end;
  end;
end;

But, it isn't just an archive. It is a secondary installer than places the unpacked file in application folders directory:

[Setup]
DisableReadyPage=True
DisableReadyMemo=True
DisableFinishedPage=True
UsePreviousSetupType=False
UsePreviousTasks=False
UsePreviousLanguage=False
FlatComponentsList=False
AlwaysShowComponentsList=False
ShowComponentSizes=False
AppName=Meeting Schedule Assistant Help Documentation
AppVersion={#AppVerText}
CreateAppDir=False
Uninstallable=no
OutputBaseFilename=MSAHelpDocumentationSetup
SignTool=SignTool /d {#SignedDesc} /du $q{#AppURL}$q /f {#SignedPfx} /p {#SignedPw} /t {#SignedTimeStamp} /v /fd SHA256 $f
AppId={{#####}

[Files]
Source: "MeetSchedAssist.chm"; DestDir: "{param:InstallPath}"; Flags: ignoreversion


I also offer the user to download this setup from within my software and run it to install the help. I'll read up on the things you mentioned.

Andrew

ASSE André

unread,
Aug 16, 2025, 4:03:10 AMAug 16
to inno...@googlegroups.com
Je saisis le même canal pour vous dire merci 

--
You received this message because you are subscribed to the Google Groups "innosetup" group.
To unsubscribe from this group and stop receiving emails from it, send an email to innosetup+...@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/innosetup/ceca70fc-33ca-4591-83e9-8fc2a8afdf8cn%40googlegroups.com.
Reply all
Reply to author
Forward
0 new messages