Marquee progress bar on TOutputProgressWizardPage

[mpri...@gmail.com]

Changes in implementation of TOutputProgressWizardPage.SetProgress on Inno Setup 6.1 prevented marquee progress bar on TOutputProgressWizardPage. It's particularly the FProgressBar.Style := npbstNormal;

The marquee progress bar is useful for many cases. For an example:

https://stackoverflow.com/q/45856503/850848

Please change the implementation to allow the marquee progress bar again.

Thanks.

Martin

[Martijn Laan]

Op 25-12-2020 om 18:12 schreef mpri...@gmail.com:

Changes in implementation of TOutputProgressWizardPage.SetProgress on Inno Setup 6.1 prevented marquee progress bar on TOutputProgressWizardPage. It's particularly the FProgressBar.Style := npbstNormal;

TOutputProgressWizardPage never supported a marquee progress bar. To get a visible progress bar a maximum is needed but a marquee progress bar doesn't have a maximum. Additionally there's no proper way to get it to animate.

I see the SO post sets a maximum anyway as a workaround and also calls SetProgress again to get it to animate but it would really be much better if you could post about such limitations here instead of (or at least together with) posting workarounds on SO. Otherwise these limitations can never can be eliminated. Going for a workaround anyway is risky since it could break.

Another prime example is https://stackoverflow.com/questions/41021292/inno-setup-language-selector-with-vcl-styles

Could you consider posting here more when you post workarounds on SO so we can discuss how to solve the limitations? That would be great.

Best wishes and greetings,
Martijn

[mpri...@gmail.com]

I understand all that. I believe that a significant portion of Pascal Script code use is about hacking Inno Setup to some degree. And in all these cases, it's only natural that sometimes it happens that a new version of Inno Setup breaks such code. So I do not object that you changed the behaviour. That's perfectly fine.

But as in this particular case your change imo does not require that the marquee progress cannot be set programmatically anymore, I'm asking you to reintroduce that option. And actually, yes, while we discuss this, I believe that adding the marquee style to the official API would be a good idea. Thanks!

Regarding the other link/question: A new event that occurs prior to language selection might be useful sometimes. Though I personally dislike the styled applications.

Thanks for all your work on Inno Setup.

[Martijn Laan]

Op 5-1-2021 om 10:30 schreef mpri...@gmail.com:

I believe that adding the marquee style to the official API would be a good idea. Thanks!

I've added a new CreateMarqueeProgressWizardPage support function to show marquee progress to the user. See https://jrsoftware.github.io/issrc/Examples/AllPagesExample.iss for an example.

Greetings,
Martijn

[mpri...@gmail.com]

Thanks! I'll update my Stack Overflow post, once it's released.