iniparse fail on empty files.

[Tim Lauridsen]

If you use iniparse with an empty file then you get this Traceback.

parser.readfp(confpp_obj)
File "/usr/lib/python2.5/site-packages/iniparse/compat.py", line 106, in readfp
self.data.readfp(fp)
File "/usr/lib/python2.5/site-packages/iniparse/ini.py", line 563, in readfp
if line and line[-1]=='\n':
UnboundLocalError: local variable 'line' referenced before assignment

I have attached a patch to fix it, please check if it look ok, before i commit it.

Tim

[Paramjit Oberoi]

This change makes some tests fail... It's really to run the tests -
from the iniparse directory, just type './runtests.py'. They run
pretty quickly too - it takes 0.3 seconds on my machine.

Regarding the problem: How about just initializing 'line' to 'None'
before the loop?

Also, could you add a test to test_misc.py that checks that an empty
file is parsed and written out correctly?

Thanks,
-param

[Tim Lauridsen]

Paramjit Oberoi wrote:
> This change makes some tests fail... It's really to run the tests -
> from the iniparse directory, just type './runtests.py'. They run
> pretty quickly too - it takes 0.3 seconds on my machine.
>
> Regarding the problem: How about just initializing 'line' to 'None'
> before the loop?
>

Yes, i though it was some indentation issue, i should have run the
tests. :)

> Also, could you add a test to test_misc.py that checks that an empty
> file is parsed and written out correctly?
>
> Thanks,
> -param
>

Here is a new patch there fixes the issue, and also contains a test case
for an empty file.

Tim

[Paramjit Oberoi]

Looks good.

[Tim Lauridsen]

Paramjit Oberoi wrote:
> Looks good.
>
OK, committed

Tim