Error when starting the proctor-webapp in Windows

[Shankar Pachari]

Hi,

When starting the Proctor-webapp in Windows, connected to a git SCM, I get the following error. Can anyone let me know if this is due to a configuration issue?

I tried with an empty git repo, and also added a sample proctor-definition.json file. I get the same error.

ERROR [ProctorWebappTasks-Thread-0][2020-08-05 17:43:55,897] [com.indeed.proctor.store.async.AsyncInitializedProctorStore.lambda$null$0] - Failed to initialize ProctorStore 5 times

java.lang.RuntimeException: com.indeed.proctor.store.StoreException$TestUpdateException: Failed to perform write operation to cache.

        at com.google.common.base.Throwables.propagate(Throwables.java:160)

        at com.indeed.proctor.store.cache.CachingProctorStore.<init>(CachingProctorStore.java:65)

        at com.indeed.proctor.webapp.db.GitProctorStoreFactory.createStore(GitProctorStoreFactory.java:154)

        at com.indeed.proctor.webapp.db.GitProctorStoreFactory.getTrunkStore(GitProctorStoreFactory.java:127)

        at com.indeed.proctor.webapp.util.RetryWithExponentialBackoff.retry(RetryWithExponentialBackoff.java:41)

        at com.indeed.proctor.store.async.AsyncInitializedProctorStore.lambda$new$1(AsyncInitializedProctorStore.java:50)

        at java.util.concurrent.FutureTask.run(Unknown Source)

        at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(Unknown Source)

        at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(Unknown Source)

        at java.util.concurrent.ThreadPoolExecutor.runWorker(Unknown Source)

        at java.util.concurrent.ThreadPoolExecutor$Worker.run(Unknown Source)

        at java.lang.Thread.run(Unknown Source)

Caused by: com.indeed.proctor.store.StoreException$TestUpdateException: Failed to perform write operation to cache.

        at com.indeed.proctor.store.cache.CachingProctorStore$CacheHolder.synchronizedCacheWrite(CachingProctorStore.java:469)

        at com.indeed.proctor.store.cache.CachingProctorStore$CacheHolder.lockAndRefreshCache(CachingProctorStore.java:378)

        at com.indeed.proctor.store.cache.CachingProctorStore$CacheHolder.start(CachingProctorStore.java:401)

        at com.indeed.proctor.store.cache.CachingProctorStore.<init>(CachingProctorStore.java:62)

        ... 10 more

Caused by: java.util.regex.PatternSyntaxException: Unmatched closing ')' near index 20

test-definitions\(\w+)\definition.json

                    ^

        at java.util.regex.Pattern.error(Unknown Source)

        at java.util.regex.Pattern.compile(Unknown Source)

        at java.util.regex.Pattern.<init>(Unknown Source)

        at java.util.regex.Pattern.compile(Unknown Source)

        at com.indeed.proctor.store.GitHistoryParser.compileTestNamePattern(GitHistoryParser.java:162)

        at com.indeed.proctor.store.GitHistoryParser.<init>(GitHistoryParser.java:59)

        at com.indeed.proctor.store.GitHistoryParser.fromRepository(GitHistoryParser.java:181)

        at com.indeed.proctor.store.GitProctor.getAllHistories(GitProctor.java:217)

        at com.indeed.proctor.store.cache.CachingProctorStore$CacheHolder$7.call(CachingProctorStore.java:383)

        at com.indeed.proctor.store.cache.CachingProctorStore$CacheHolder$7.call(CachingProctorStore.java:378)

        at com.indeed.proctor.store.cache.CachingProctorStore$CacheHolder.synchronizedCacheWrite(CachingProctorStore.java:467)

        ... 13 more

INFO  [ProctorWebappTasks-Thread-2][2020-08-05 17:43:55,899] [com.indeed.proctor.webapp.util.RetryWithExponentialBackoff.sleep] - Sleep 16 seconds before retrying

[aboiv...@indeed.com]

Hi Shankar,

Thanks a lot for reporting!

It seems you identified a Windows specific issue, caused by this regular expression : 

https://code.corp.indeed.com/opensource/proctor/-/blob/master/proctor-store-git/src/main/java/com/indeed/proctor/store/GitHistoryParser.java#L163

Because Windows' File.separator is '\\' while Unix is '/', this regexp is not compatible with Windows.

I believe File.separator should be escaped, one thing to try would be replacing File.separator with Pattern.quote(File.separator).

The team doesn't have access to Windows environment to test it, but if you get successful result your contribution with a pull request will be much appreciated!

Thanks,

Andre