Getting NPEs in proctor webapp(using git)

[craus...@homeaway.com]

Occasionally, when we try to view or edit tests in the webapp(with git) we get: 

Caused by: java.lang.NullPointerException
	at com.indeed.proctor.webapp.controllers.ProctorTestDefinitionController.show(ProctorTestDefinitionController.java:221)

Hitting Clean Workspace doesn't fix it, nor does restarting the webapp. When we dig into the logs we find:

Caused by: org.eclipse.jgit.errors.MissingObjectException: Missing tree e99f64d6002ba8029d8ad5d4c35e96afe2749cd2
        at org.eclipse.jgit.internal.storage.file.WindowCursor.open(WindowCursor.java:149) ~[org.eclipse.jgit-3.4.1.201406201815-r.jar:3.4.1.201406201815-r]

which is called by:

Caused by: org.eclipse.jgit.errors.RevWalkException: Walk failure.
        at org.eclipse.jgit.revwalk.RevWalk.iterator(RevWalk.java:1259) ~[org.eclipse.jgit-3.4.1.201406201815-r.jar:3.4.1.201406201815-r]
        at com.indeed.proctor.store.GitProctor.getHistoryFromLogCommand(GitProctor.java:279) ~[proctor-store-git-1.1.12.jar:na]
        at com.indeed.proctor.store.GitProctor.getHistory(GitProctor.java:208) ~[proctor-store-git-1.1.12.jar:na]
        at com.indeed.proctor.store.GitProctor.getHistory(GitProctor.java:192) ~[proctor-store-git-1.1.12.jar:na]
        at com.indeed.proctor.common.ProctorPromoter.getMostRecentHistory(ProctorPromoter.java:284) ~[proctor-webapp-library-1.1.3.jar:na]
        at com.indeed.proctor.common.ProctorPromoter.access$000(ProctorPromoter.java:33) ~[proctor-webapp-library-1.1.3.jar:na]
        at com.indeed.proctor.common.ProctorPromoter$GetEnvironmentVersionTask.call(ProctorPromoter.java:261) ~[proctor-webapp-library-1.1.3.jar:na]
        at com.indeed.proctor.common.ProctorPromoter$GetEnvironmentVersionTask.call(ProctorPromoter.java:250) ~[proctor-webapp-library-1.1.3.jar:na]

Is there a fix for this in an upcoming release of proctor-webapp-library? 

Thanks!

[yiq...@indeed.com]

Hi,

Thank you for reporting the issue. 

It looks the history tree is complicated and breaks the traversing algorithm. 

We are investigating it. I will let you know as soon as we have some updates. 

Thanks

Yiqing

[yiq...@indeed.com]

Hi, recently we released proctor-1.1.27 and proctor-webapp-library-1.1.5. 

Please give a shot to the new version and let us know if it works. 

Thanks! 

[cnie...@homeaway.com]

Hi Yiqing,

proctor-webapp-library-1.1.4 resolved several tests that were experiencing the org.eclipse.jgit.errors.RevWalkException exception for us.  We'll report back if we see the issue again and try 1.1.5 as well.  Thanks!

Chris