Pull request 938 in include-what-you-use: Link with all targets

1 view
Skip to first unread message

notifi...@include-what-you-use.org

unread,
Jul 24, 2021, 8:56:04 AMJul 24
to include-wh...@googlegroups.com
New pull request 938 by kimgr: Link with all targets
https://github.com/include-what-you-use/include-what-you-use/pull/938

In the parent commit, I forgot to update the build so that include-what-you-use
links with all targets, which led to link failures for builds against LLVM build
trees (as opposed to the Debian packages).

While troubleshooting this, I found a patch by @Romain-Geissler-1A that I had
previously misunderstood/overlooked:
https://github.com/include-what-you-use/include-what-you-use/pull/854#issuecomment-732487734

Borrowing the link dependencies from that patch fixes the build again.

notifi...@include-what-you-use.org

unread,
Jul 24, 2021, 8:56:21 AMJul 24
to include-wh...@googlegroups.com
Comment #0 on pull request 938 by kimgr: Link with all targets
https://github.com/include-what-you-use/include-what-you-use/pull/938

@vmiklos This should fix the recent regression.

notifi...@include-what-you-use.org

unread,
Jul 25, 2021, 3:18:11 PMJul 25
to include-wh...@googlegroups.com
Comment #2 on pull request 938 by vmiklos: Link with all targets
https://github.com/include-what-you-use/include-what-you-use/pull/938

> @vmiklos This should fix the recent regression.

Yes, it does. Thanks! :-)

notifi...@include-what-you-use.org

unread,
Jul 25, 2021, 3:40:49 PMJul 25
to include-wh...@googlegroups.com
Comment #2 on pull request 938 by kimgr: Link with all targets
https://github.com/include-what-you-use/include-what-you-use/pull/938

@vmiklos Thanks!

Reply all
Reply to author
Forward
0 new messages