Re: Pull request 1253 in include-what-you-use: Add docs for always keep pragma

[notifi...@include-what-you-use.org]

Comment #1 on pull request 1253 by kimgr: Add docs for always_keep pragma
https://github.com/include-what-you-use/include-what-you-use/pull/1253

Discussions on pragma naming ongoing in: https://github.com/include-what-you-use/include-what-you-use/issues/1235

[notifi...@include-what-you-use.org]

Comment #2 on pull request 1253 by kadircet: Add docs for always_keep pragma
https://github.com/include-what-you-use/include-what-you-use/pull/1253

rebase to pick up CI fix.

Fixes https://github.com/include-what-you-use/include-what-you-use/issues/1235.

[notifi...@include-what-you-use.org]

Comment #3 on pull request 1253 by kimgr: Add docs for always_keep pragma
https://github.com/include-what-you-use/include-what-you-use/pull/1253

Might be a good idea to also cover `always_keep` in the summary section at the end: https://github.com/include-what-you-use/include-what-you-use/blob/master/docs/IWYUPragmas.md#which-pragma-should-i-use.

We can't really merge this until the pragma is implemented. The semantics look right to me, do you want to take a stab at it, or should I?

[notifi...@include-what-you-use.org]

Comment #4 on pull request 1253 by kadircet: Add docs for always_keep pragma

https://github.com/include-what-you-use/include-what-you-use/pull/1253

> Might be a good idea to also cover always_keep in the summary section at the end: https://github.com/include-what-you-use/include-what-you-use/blob/master/docs/IWYUPragmas.md#which-pragma-should-i-use.

Thanks, updated that part too.

> We can't really merge this until the pragma is implemented. The semantics look right to me, do you want to take a stab at it, or should I?

It'd be great if you can take a stab at that, as I am not really familiar with the codebase